Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated test file #39

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Updated test file #39

merged 3 commits into from
Apr 16, 2024

Conversation

tewaro
Copy link

@tewaro tewaro commented Apr 15, 2024

No description provided.

@tewaro tewaro force-pushed the AdityaAtulTewari/prefixsum-reenable-test branch from 553e98d to 79a5e03 Compare April 15, 2024 19:11
meyerzinn
meyerzinn approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@meyerzinn meyerzinn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine if we're confident the threads > 1 case is correct. If the memory sanitizer detects issues again, we should look at replacing this.

@tewaro tewaro merged commit 4731af3 into master Apr 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meyerzinn meyerzinn meyerzinn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tewaro @meyerzinn