refactor: Perform codebase refactor to separate appropriate functions #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request involves several changes to the
phylo2vec
library, focusing on code organization and refactoring. The primary changes include moving type definitions to a newtypes
module, updating import paths, and refactoring functions to use the new module. Additionally, a newnewick
module has been introduced to handle Newick string construction.Code Organization and Refactoring:
phylo2vec/src/tree_vec/mod.rs
: Introduced a newtypes
module and updated type references to use this module. [1] [2] [3] [4] [5] [6]phylo2vec/src/tree_vec/ops/mod.rs
: Added a newnewick
module and refactored theto_newick
function to use this module.phylo2vec/src/tree_vec/ops/vector.rs
: Removed type aliases and Newick string construction functions, which were moved to the newtypes
andnewick
modules respectively. [1]R1, [2]phylo2vec/src/tree_vec/types.rs
: Created a newtypes
module to define type aliases forPair
,Ancestry
, andPairsVec
.Function and Type Updates:
phylo2vec/benches/benchmarks/get_ancestry_dtype.rs
: Updated type references fromops::vector::PairsVec
toPairsVec
. [1] [2] [3] [4]py-phylo2vec/src/lib.rs
: Updated thebuild_newick
function to use the newops::newick::build_newick
function.Related Issues
Closes #50