Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Perform codebase refactor to separate appropriate functions #51

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

lsetiawan
Copy link
Member

This pull request involves several changes to the phylo2vec library, focusing on code organization and refactoring. The primary changes include moving type definitions to a new types module, updating import paths, and refactoring functions to use the new module. Additionally, a new newick module has been introduced to handle Newick string construction.

Code Organization and Refactoring:

Function and Type Updates:

Related Issues

Closes #50

@lsetiawan lsetiawan requested a review from Copilot December 11, 2024 19:32

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no suggestions.

Files not reviewed (3)
  • phylo2vec/benches/benchmarks/get_ancestry_dtype.rs: Evaluated as low risk
  • phylo2vec/src/tree_vec/mod.rs: Evaluated as low risk
  • phylo2vec/src/tree_vec/ops/avl.rs: Evaluated as low risk
@lsetiawan lsetiawan merged commit fb06aca into uw-ssec:dev Dec 11, 2024
2 checks passed
@lsetiawan lsetiawan deleted the refactor-modules branch December 11, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: Refactor codebase to be more clear between operations
1 participant