Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Initialize log file permissions #39

Merged
merged 1 commit into from
Aug 14, 2020
Merged

fix: Initialize log file permissions #39

merged 1 commit into from
Aug 14, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 14, 2020

  1. It seems that someone will run V2Ray directly through commands instead of systemd first, which will cause wrong Log file permissions and affect subsequent systemd operations.

issue #38

1. It seems that someone will run V2Ray directly through commands instead of systemd first, which will cause wrong Log file permissions and affect subsequent systemd operations.

issue #38
@ghost ghost requested review from IceCodeNew and RPRX August 14, 2020 13:08
@ghost ghost assigned IceCodeNew Aug 14, 2020
@IceCodeNew
Copy link
Collaborator

LGTM.

@IceCodeNew IceCodeNew merged commit 4eaeeac into master Aug 14, 2020
@IceCodeNew IceCodeNew deleted the develop branch August 14, 2020 13:38
@ghost ghost restored the develop branch August 14, 2020 14:05
@RPRX
Copy link
Contributor

RPRX commented Aug 14, 2020

作为配套,00_log.json 应有相应的配置。

@ghost
Copy link
Author

ghost commented Aug 14, 2020

用者未必會使用該腳本提供的配置結構,這僅僅是一個簡單的參照,決定權在用者手上。

@IceCodeNew
Copy link
Collaborator

作为配套,00_log.json 应有相应的配置。

用者未必會使用該腳本提供的配置結構,這僅僅是一個簡單的參照,決定權在用者手上。

我觉得这里还是评论 #37 (review) 的衍生
眼下我暂时无空做一个 PR 来从环境变量里读取用户自定义配置,并从脚本里彻底替换掉相关硬编码的路径,欢迎其他人贡献。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants