Don't store default_settings in SettingsList

valadaptive · Jan 10, 2025 · a0a6927 · a0a6927
1 parent 969322a
commit a0a6927
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/crates/ae-plugin/src/lib.rs b/crates/ae-plugin/src/lib.rs
@@ -150,7 +150,7 @@ impl AdobePluginGlobal for Plugin {
         Self::map_params(
             params,
             &self.settings.setting_descriptors,
-            &self.settings.default_settings,
+            &NtscEffectFullSettings::default(),
             &NtscEffectFullSettings::legacy_value(),
         )?;
 

diff --git a/crates/ntscrs/src/settings/settings.rs b/crates/ntscrs/src/settings/settings.rs
@@ -404,7 +404,6 @@ impl GetAndExpect for HashMap<String, JsonValue> {
 #[derive(Debug, Clone)]
 pub struct SettingsList<T: Settings> {
     pub setting_descriptors: Box<[SettingDescriptor<T>]>,
-    pub default_settings: Box<T>,
 }
 
 impl<T: Settings> SettingsList<T> {
@@ -413,7 +412,6 @@ impl<T: Settings> SettingsList<T> {
     pub fn new() -> Self {
         Self {
             setting_descriptors: T::setting_descriptors(),
-            default_settings: Box::new(Default::default()),
         }
     }
 

diff --git a/crates/openfx-plugin/src/lib.rs b/crates/openfx-plugin/src/lib.rs
@@ -691,7 +691,7 @@ unsafe fn action_describe_in_context(descriptor: OfxImageEffectHandle) -> OfxRes
         param_suite,
         param_set,
         &data.settings_list.setting_descriptors,
-        &data.settings_list.default_settings,
+        &NtscEffectFullSettings::default(),
         c"",
     )?;