Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maze Game and Inverted color #117

Merged
merged 8 commits into from
Oct 18, 2024
Merged

Maze Game and Inverted color #117

merged 8 commits into from
Oct 18, 2024

Conversation

bhaviya18
Copy link
Contributor

@bhaviya18 bhaviya18 commented Oct 14, 2024 •
edited by vansh-codes
Loading

I have added the maze game using react. I hope you will like it.
Closes: #111
Closes: #112
https://github.com/user-attachments/assets/6db02edd-f899-4a3e-9441-4d48bbdf1c47

@bhaviya18
Inverted Mode
e89fe78 
I added inverted mode toggle button using react.
fixed issue
@bhaviya18
Maze Game
92b1ae4 
I have added maze game using react. I hope you will like it.
fixed issue vansh-codes#111
@vercel Vercel
Copy link

vercel bot commented Oct 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chaos-web ❌ Failed (Inspect) Oct 18, 2024 1:01pm

@github-actions GitHub Actions
Copy link
Contributor

Thank you for submitting your chaotic pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@bhaviya18 bhaviya18 closed this Oct 14, 2024
@bhaviya18 bhaviya18 changed the title Maze Game Maze Game and Inverted color Oct 14, 2024
@bhaviya18 bhaviya18 reopened this Oct 14, 2024
@bhaviya18
Copy link
Contributor Author

bhaviya18 commented Oct 14, 2024 •
edited
Loading

I raised 2 issues, but it is not taking them separately, I dont know how to manage that. But can you please assign me points accordingly, as I resolved 2 issues. And can you kindly guide me on how to seperate the PRs.

@vansh-codes
Copy link
Owner

vansh-codes commented Oct 14, 2024 •
edited
Loading

@bhaviya18

  1. which two issues did you work upon?
  2. I dont find anything chaotic in the recording you shared, can you rework on it and make it chaotic in functionality along with UI
  3. Resolve merge conflicts
  4. After all these 3 tasks, commit and tag me

@bhaviya18
Copy link
Contributor Author

bhaviya18 commented Oct 14, 2024 •
edited
Loading

my 2 issues were #111 and #112. I dont know how to make separate PRs for them. So I had to add both of the issues in the same PRs as mentioned. Also I will try to add more chaos to the maze game as you mentioned. Also can you guide me with what issue is arising.

@bhaviya18
Added invert color toggle button and Maze game
c87976b 
I have added more chaos to the maze game as you mentioned. I have also added invert color toggle button.
fixed issue vansh-codes#111
and fixed issue vansh-codes#112

I hope you will like it
@bhaviya18
Update InvertColorToggle.jsx
887e2de
@bhaviya18
Copy link
Contributor Author

i have added invert color toggle button as well as added more chaos to maze game.
fixed issue #111 and #112

Uploading maze game and invert button.mp4…

@vansh-codes
Copy link
Owner

resolve conflicts

@vansh-codes vansh-codes added the conflicts PR has merge conflicts label Oct 15, 2024
@bhaviya18
Copy link
Contributor Author

I cannot understand the conflicts. Can you guide me please.

@vansh-codes
Copy link
Owner

The place where you added code, there already exists some code thats why it has merge conflicts, if you have added some new lines then shift the position of those lines which are creating conflicts, try understanding if not then search on google or youtube once, it would help you understand better

@bhaviya18
Copy link
Contributor Author

bhaviya18 commented Oct 15, 2024 •
edited
Loading

Please review @vansh-codes.

@bhaviya18
Copy link
Contributor Author

Please review my PR.

@vansh-codes
Copy link
Owner

Share screenshots and videos of your work

@bhaviya18
Copy link
Contributor Author

bhaviya18 commented Oct 17, 2024 •
edited
Loading

Here is the video of my work @vansh-codes
I have made the invert toggle button for negative image issue #112
and I have made maze game issue #111
https://github.com/user-attachments/assets/75e55873-085b-4a2b-a3a2-6cfe74e3f96f

@vansh-codes vansh-codes self-requested a review October 17, 2024 10:34
@vansh-codes vansh-codes added enhancement New feature or request gssoc-ext GSSOC'24 Extd Participant level3 awards 45 points hacktoberfest-accepted hacktoberfest accepted chaos Chaotic update Reactv2 Implementing in React and removed conflicts PR has merge conflicts labels Oct 17, 2024
@vansh-codes
Copy link
Owner

image

Fix this errors

@bhaviya18
Copy link
Contributor Author

image
I cant find any issue in my code. Im lost, also Im a beginner, so sorry for the inconvenience but I cannot understand it. Can you help me.

@vansh-codes
Copy link
Owner

Fix the conflicts

@vansh-codes vansh-codes added the conflicts PR has merge conflicts label Oct 17, 2024
@bhaviya18
Copy link
Contributor Author

@vansh-codes Review please.

@vansh-codes vansh-codes self-requested a review October 18, 2024 13:18
@vansh-codes vansh-codes merged commit 61da183 into vansh-codes:main Oct 18, 2024
1 check failed
@bhaviya18
Copy link
Contributor Author

Thank you soo much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vansh-codes vansh-codes vansh-codes approved these changes

Assignees
No one assigned
Labels
chaos Chaotic update conflicts PR has merge conflicts enhancement New feature or request gssoc-ext GSSOC'24 Extd Participant hacktoberfest-accepted hacktoberfest accepted level3 awards 45 points Reactv2 Implementing in React
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chaotic Feat: Add an invert color button Chaotic Feat: Chaotic Maze game
2 participants
@bhaviya18 @vansh-codes