Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #94

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Update README.md #94

merged 3 commits into from
Oct 14, 2024

Conversation

eshalshaikh07
Copy link
Contributor

@eshalshaikh07 eshalshaikh07 commented Oct 13, 2024 •
edited by vansh-codes
Loading

Closes: #93
Hey!!
added animations hope you like it

@eshalshaikh07
Update README.md
1aaa19f 
Hey!!
added animations hope you like it
@vercel Vercel
Copy link

vercel bot commented Oct 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chaos-web ❌ Failed (Inspect) Oct 14, 2024 5:54am

@github-actions GitHub Actions
Copy link
Contributor

Thank you for submitting your chaotic pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@vansh-codes
Copy link
Owner

Please share the video of the new readme you created

@eshalshaikh07
Copy link
Contributor Author

Please share the video of the new readme you created
https://github.com/eshalshaikh07/ChaosWeb/blob/main/README.md check this!

@eshalshaikh07
Copy link
Contributor Author

dropped the link please check!

@vansh-codes
Copy link
Owner

Remove the red animated lines, its too distracting and doesnt looks good! Remove them and commit so I can merge

@vansh-codes vansh-codes self-requested a review October 14, 2024 05:28
vansh-codes
vansh-codes requested changes Oct 14, 2024
View reviewed changes
Copy link
Owner

@vansh-codes vansh-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the asked changes

  • remove red animation lines

@vansh-codes vansh-codes added the changes requested Requested changes needs to be updated label Oct 14, 2024
@eshalshaikh07
Update README.md
fa918b9 
changes done!
@eshalshaikh07
Copy link
Contributor Author

https://github.com/eshalshaikh07/ChaosWeb/blob/main/README.md removed red lines!!!

vansh-codes
vansh-codes approved these changes Oct 14, 2024
View reviewed changes
Copy link
Owner

@vansh-codes vansh-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 💥

@vansh-codes vansh-codes added documentation Improvements or additions to documentation gssoc-ext GSSOC'24 Extd Participant level1 awards 10 points hacktoberfest hacktoberfest registered hacktoberfest-accepted hacktoberfest accepted chaos Chaotic update and removed changes requested Requested changes needs to be updated labels Oct 14, 2024
@vansh-codes
Copy link
Owner

Share your issue link asap

@vansh-codes vansh-codes merged commit 2c6b996 into vansh-codes:main Oct 14, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vansh-codes vansh-codes vansh-codes approved these changes

Assignees
No one assigned
Labels
chaos Chaotic update documentation Improvements or additions to documentation gssoc-ext GSSOC'24 Extd Participant hacktoberfest hacktoberfest registered hacktoberfest-accepted hacktoberfest accepted level1 awards 10 points
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation Chaos: Readme more animated
2 participants
@eshalshaikh07 @vansh-codes