-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isolate Windows specific changes #12
Conversation
fpseverino
commented
Nov 6, 2024
- Isolate Windows specific changes from Windows support and other various changes #10
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
- Coverage 96.07% 88.83% -7.24%
==========================================
Files 7 9 +2
Lines 331 439 +108
==========================================
+ Hits 318 390 +72
- Misses 13 49 +36
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me. This code now doesn't have much in terms of Windows specifics except in the test expectations.
All right, thanks a lot Saleem! |