Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate Windows specific changes #12

Closed
wants to merge 7 commits into from

Conversation

fpseverino
Copy link
Member

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 97.51553% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.83%. Comparing base (567d515) to head (668ab71).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/Zip/Zip.swift 96.74% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (567d515) and HEAD (668ab71). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (567d515) HEAD (668ab71)
7 5
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   96.07%   88.83%   -7.24%     
==========================================
  Files           7        9       +2     
  Lines         331      439     +108     
==========================================
+ Hits          318      390      +72     
- Misses         13       49      +36     
Files with missing lines Coverage Δ
Sources/Zip/ArchiveFile.swift 100.00% <100.00%> (ø)
Sources/Zip/URL+nativePath.swift 100.00% <100.00%> (ø)
Sources/Zip/Zip+ProcessedFilePath.swift 100.00% <100.00%> (ø)
Sources/Zip/Zip.swift 94.42% <96.74%> (+1.05%) ⬆️

... and 3 files with indirect coverage changes

Sources/Zip/ArchiveFile.swift Outdated Show resolved Hide resolved
Sources/Zip/Zip+ProcessedFilePath.swift Outdated Show resolved Hide resolved
Sources/Zip/Zip.swift Show resolved Hide resolved
@fpseverino fpseverino requested a review from compnerd November 6, 2024 22:19
Copy link

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. This code now doesn't have much in terms of Windows specifics except in the test expectations.

@fpseverino
Copy link
Member Author

All right, thanks a lot Saleem!

@fpseverino fpseverino marked this pull request as draft November 7, 2024 11:07
@fpseverino fpseverino closed this by deleting the head repository Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants