Lazy imports (from django) #339

tony · 2022-04-30T10:33:43Z

No description provided.

Remove django-specific stuff so they're generic. Use pytest for sys paths. See also: https://github.com/django/django/blob/4.0.4/django/utils/module_loading.py

See also: https://github.com/django/django/blob/4.0.4/django/utils/module_loading.py

codecov · 2022-04-30T10:34:38Z

Codecov Report

Merging #339 (eb7985a) into master (4fb953f) will decrease coverage by 1.70%.
The diff coverage is 47.28%.

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
- Coverage   73.21%   71.50%   -1.71%     
==========================================
  Files          23       30       +7     
  Lines        1833     1962     +129     
==========================================
+ Hits         1342     1403      +61     
- Misses        491      559      +68

Impacted Files	Coverage Δ
tests/utils/test_module/another_bad_module.py	`0.00% <0.00%> (ø)`
tests/utils/test_module/another_good_module.py	`0.00% <0.00%> (ø)`
...tils/test_module/child_module/grandchild_module.py	`0.00% <0.00%> (ø)`
libvcs/utils/module_loading.py	`48.64% <48.64%> (ø)`
tests/utils/test_module/bad_module.py	`50.00% <50.00%> (ø)`
tests/utils/test_module_loading.py	`50.61% <50.61%> (ø)`
tests/utils/test_module/good_module.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fb953f...eb7985a. Read the comment docs.

tony added 3 commits April 30, 2022 04:17

tests(module_loading): Port tests from django 4.0 w/ touchups

a3a63b5

Remove django-specific stuff so they're generic. Use pytest for sys paths. See also: https://github.com/django/django/blob/4.0.4/django/utils/module_loading.py

feat(utils): module_loading.py (from django 4.x)

a752afe

See also: https://github.com/django/django/blob/4.0.4/django/utils/module_loading.py

🔧 setup.cfg(pytest): Skip test_module/ sample directory

eb7985a

tony force-pushed the master branch 3 times, most recently from 5354b23 to effff43 Compare July 13, 2022 21:24

tony force-pushed the master branch from f5b8e49 to ce03b3a Compare March 15, 2023 12:41

tony force-pushed the master branch 4 times, most recently from cf9f3ef to 410e041 Compare May 27, 2023 13:25

tony force-pushed the master branch from 6b51eda to 9b579d6 Compare March 24, 2024 16:02

tony force-pushed the master branch from 9b797e7 to bc6e897 Compare October 12, 2024 15:51

tony force-pushed the master branch 2 times, most recently from 7f69eab to c480bb4 Compare November 24, 2024 15:12

tony force-pushed the master branch from bf492cf to 27cfdb0 Compare January 5, 2025 19:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lazy imports (from django) #339

Lazy imports (from django) #339

tony commented Apr 30, 2022

codecov bot commented Apr 30, 2022

Lazy imports (from django) #339

Are you sure you want to change the base?

Lazy imports (from django) #339

Conversation

tony commented Apr 30, 2022

codecov bot commented Apr 30, 2022

Codecov Report