Zero vector frequency randomization #770
Conversation
Also removed timer reinit logic that was triggered if ARR differed from the calfulated zvf. Verified that floatwheel still rides fine.
|
This one has many potential dangers and will almost certainly not work with dual motors. I also don't know how much the rand-function will impact performance. It will take me quite significant effort to test all of this. Before I do that, have you confirmed that it actually has any benefits? Is it more silent? Does it help with EMI? If it is just an "interesting feature" without any observed worthwhile benefits I don't think it is worth adding as it several potential problems that I might not even be able to find yet and it has impact on the performance. |
|
I agree that this is a risky change. In my opinion it does provide improvements in the sound characteristics of the motor.
I do not have a way of measuring EMI explicitly, neither is this my goal with this change. What are your concerns regarding the change not working in dual motor setup? I'll be happy to address them better. |
|
My floatwheel has an almost entirely silent motor (maybe not all of them are like that). Having that almost non-existent sound change characteristics slightly is not a good enough motivation for me for a change with this impact. Maybe I'm wrong here though and my floatwheel is an exception, so if you have some demo and good arguments I'm prepared to change my mind here. How does it change the HFI-sound? That is one area where there potentially is something to gain. Here is one comment about it from the discord that is not very convincing: |
Adds Zero vector randomization so the acoustic profile of FET switching is less annoying.
I tested this change on my Floatwheel and made sure that
all_fwtarget builds without issues.I don't have a good way of testing this change on a dual-motor setup, any tips on how to do this would be appreciated.