Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug 1217 #656

Merged
merged 5 commits into from
Dec 20, 2024
Merged

Fix bug 1217 #656

merged 5 commits into from
Dec 20, 2024

Conversation

thexqn
Copy link
Contributor

@thexqn thexqn commented Dec 17, 2024

问题:模型B继承于模型A,当模型A中的字段A删除时,订阅信息中模型B的字段A没有被清理,会导致一定程度的残留,建议修复。

@@ -740,6 +737,9 @@ def delete(cls, type_id, attr_ids=None):
item = CITypeTrigger.get_by(type_id=_type_id, attr_id=attr_id, to_dict=False, first=True)
item and item.soft_delete(commit=False)

for item in PreferenceShowAttributes.get_by(type_id=type_id, attr_id=attr_id, to_dict=False):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是不是应该是_type_id

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢提醒,已经修正,测试正常。

@pycook pycook merged commit 747475b into veops:master Dec 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants