Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use shrink-to-fit crate instead #75777

Merged
merged 26 commits into from
Feb 8, 2025
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 7, 2025

What?

Use shrink-to-fit crate instead of inline trait in turbo-tasks.

Why?

It's a separate crate, so SWC AST implement the ShrinkToFit trait.

Closes PACK-3923

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Feb 7, 2025
Copy link
Member Author

kdy1 commented Feb 7, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kdy1 kdy1 changed the title Remove shrink_to_fit module refactor: Use shrink-to-fit crate instead Feb 7, 2025
@ijjk
Copy link
Member

ijjk commented Feb 7, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js kdy1/shrink-to-fit-module Change
buildDuration 17.1s 15.7s N/A
buildDurationCached 14.8s 12.5s N/A
nodeModulesSize 392 MB 392 MB
nextStartRea..uration (ms) 420ms 417ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js kdy1/shrink-to-fit-module Change
5306-HASH.js gzip 54.2 kB 54.2 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.5 kB 34.5 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 53 kB 53 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js kdy1/shrink-to-fit-module Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js kdy1/shrink-to-fit-module Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js kdy1/shrink-to-fit-module Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js kdy1/shrink-to-fit-module Change
index.html gzip 523 B 523 B
link.html gzip 539 B 537 B N/A
withRouter.html gzip 519 B 520 B N/A
Overall change 523 B 523 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js kdy1/shrink-to-fit-module Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 211 kB 211 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js kdy1/shrink-to-fit-module Change
middleware-b..fest.js gzip 676 B 672 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js kdy1/shrink-to-fit-module Change
app-page-exp...dev.js gzip 393 kB 393 kB
app-page-exp..prod.js gzip 132 kB 132 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 381 kB 381 kB
app-page.run..prod.js gzip 128 kB 128 kB
app-route-ex...dev.js gzip 39.3 kB 39.3 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 40.9 kB 40.9 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 31.5 kB 31.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 60.5 kB 60.5 kB
Overall change 1.67 MB 1.67 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js kdy1/shrink-to-fit-module Change
0.pack gzip 2.1 MB 2.11 MB ⚠️ +3.75 kB
index.pack gzip 75.8 kB 75 kB N/A
Overall change 2.1 MB 2.11 MB ⚠️ +3.75 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 51f48e7

@ijjk
Copy link
Member

ijjk commented Feb 7, 2025

Failing test suites

Commit: 51f48e7

pnpm test-dev test/development/app-dir/build-error-logs/build-error-logs.test.ts

  • build-error-logs > should only log error a single time
Expand output

● build-error-logs › should only log error a single time

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  252 |   let next: NextInstance | undefined
  253 |   if (!skipped) {
> 254 |     beforeAll(async () => {
      |     ^
  255 |       next = await createNext(options)
  256 |     })
  257 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils/index.ts:254:5)
  at development/app-dir/build-error-logs/build-error-logs.test.ts:5:46
  at Object.describe (development/app-dir/build-error-logs/build-error-logs.test.ts:4:1)

Read more about building and testing Next.js in contributing.md.

Base automatically changed from kdy1/swc-core-13-2 to canary February 8, 2025 00:26
@kdy1 kdy1 force-pushed the kdy1/shrink-to-fit-module branch from e69d1b9 to 64d3519 Compare February 8, 2025 00:27
@kdy1 kdy1 force-pushed the kdy1/shrink-to-fit-module branch from 64d3519 to 0cc017b Compare February 8, 2025 00:27
@kdy1 kdy1 marked this pull request as ready for review February 8, 2025 00:30
@kdy1 kdy1 requested review from bgw and sokra and removed request for bgw February 8, 2025 00:30
turbopack/crates/turbo-rcstr/src/lib.rs Show resolved Hide resolved
@kdy1 kdy1 enabled auto-merge (squash) February 8, 2025 00:38
@kdy1 kdy1 merged commit b5c6404 into canary Feb 8, 2025
131 checks passed
@kdy1 kdy1 deleted the kdy1/shrink-to-fit-module branch February 8, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Turbopack team PRs by the Turbopack team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants