Change IPs from external to local #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ustiugov
reviewed
Apr 10, 2024
|
@lrq619 Please review |
lrq619
previously approved these changes
Apr 18, 2024
Signed-off-by: Leonid Kondrashov <[email protected]>
Signed-off-by: Leonid Kondrashov <[email protected]>
|
The gVisor test was fixed by increased timeout. I guess the function was not ready for the test because it failed a single invocation test and passed multiple invocations later. @lrq619 Please review |
lrq619
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change the IPs of k8s nodes to the experimental subnet instead of the default (which is control in CloudLab).
Implementation Notes ⚒️
External Dependencies 🍀
Breaking API Changes⚠️