Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix firecracker linux image download #996

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fix firecracker linux image download #996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bin/.gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ default-rootfs.img filter=lfs diff=lfs merge=lfs -text
grpcurl filter=lfs diff=lfs merge=lfs -text
containerd-shim-runsc-v1 filter=lfs diff=lfs merge=lfs -text
gvisor-containerd filter=lfs diff=lfs merge=lfs -text
vmlinux-5.10.186 filter=lfs diff=lfs merge=lfs -text
3 changes: 3 additions & 0 deletions bin/vmlinux-5.10.186
View file
Open in desktop
Git LFS file not shown
4 changes: 2 additions & 2 deletions scripts/setup/setup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ func SetupFirecrackerContainerd() error {
return err
}

// kernel image
kernelImgPath, err := utils.DownloadToTmpDir(configs.VHive.FirecrackerKernelImgDownloadUrl)
// kernel image; better to download it from AWS S3 but it takes too much time on NTU network
kernelImgPath, err := utils.GetVHiveFilePath(path.Join(binsDir, "vmlinux-5.10.186"))
if !utils.CheckErrorWithMsg(err, "Failed to download kernel image!\n") {
return err
}
Expand Down
Loading