Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional Strict Mode GC Zoom Extraction #88

Closed
HeikoKlare opened this issue Jul 5, 2024 · 0 comments · Fixed by eclipse-platform/eclipse.platform.swt#1753
Closed

Optional Strict Mode GC Zoom Extraction #88

HeikoKlare opened this issue Jul 5, 2024 · 0 comments · Fixed by eclipse-platform/eclipse.platform.swt#1753
Assignees
Labels
Enhancement A Request for an Enhancement of an Existing Feature HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT Vector Issues specifically relevant for Vector Informatik
Milestone

Comments

@HeikoKlare
Copy link
Contributor

In case a GC is initialized with data that does not contain a valid nativeZoom, the value is extracted via the operating system handle. This is less efficient than directly passing the zoom to the GC, but will only occur in case someone (illegally) implements Drawable.

For those consumers who have a custom Drawable implementation (even though not allowed by the API), it could be beneficial to allow some more strict handling to get aware of something less efficient happening. A concrete solution could be a strict mode that throws an exception in case GC.extractZoom() is called, which can be enabled via a flag / VM argument.

@HeikoKlare HeikoKlare added this to HiDPI Jul 5, 2024
@HeikoKlare HeikoKlare converted this from a draft issue Jul 5, 2024
@HeikoKlare HeikoKlare added SWT Issue for SWT HiDPI A HiDPI-Related Issue or Feature Enhancement A Request for an Enhancement of an Existing Feature labels Jul 5, 2024
@HeikoKlare HeikoKlare moved this from 🆕 New to 🔖 Ready: Atomic in HiDPI Jul 5, 2024
@HeikoKlare HeikoKlare added this to the 4.35 M3 milestone Jan 13, 2025
@HeikoKlare HeikoKlare added the Vector Issues specifically relevant for Vector Informatik label Jan 13, 2025
@akoch-yatta akoch-yatta moved this from 🔖 Ready: Atomic to 🏗 In Work: Short in HiDPI Jan 22, 2025
@akoch-yatta akoch-yatta self-assigned this Jan 22, 2025
@akoch-yatta akoch-yatta moved this from 🏗 In Work: Short to 👀 In Review in HiDPI Jan 22, 2025
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in HiDPI Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A Request for an Enhancement of an Existing Feature HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT Vector Issues specifically relevant for Vector Informatik
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants