Unify internal strict mode flag for win32 and gtk #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoch-yatta
force-pushed
the
gc-strict-mode
branch
from
a1c947d to
0f86d60
Compare
Test Results 492 files - 2 492 suites - 2 7m 21s ⏱️ -56s Results for commit 6c3b12c. ± Comparison against base commit 3cd1f36. This pull request removes 227 tests.This pull request skips 1 test.♻️ This comment has been updated with latest results. |
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/GC.java
Outdated
Show resolved
Hide resolved
akoch-yatta
force-pushed
the
gc-strict-mode
branch
from
0f86d60 to
22c5cea
Compare
akoch-yatta
changed the title
akoch-yatta
force-pushed
the
gc-strict-mode
branch
from
22c5cea to
b1fa24e
Compare
HeikoKlare
reviewed
Jan 22, 2025
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Device.java
Outdated
Show resolved
Hide resolved
akoch-yatta
force-pushed
the
gc-strict-mode
branch
from
b1fa24e to
c763395
Compare
HeikoKlare
approved these changes
Jan 23, 2025
This contribution renames the internal strict mode flag in GTK from org.eclipse.swt.internal.gtk.enableStrictChecks to org.eclipse.swt.internal.enableStrictChecks and adds it to win32 to be used to check for correctly configured GCs for monitor-specific-scaling
HeikoKlare
force-pushed
the
gc-strict-mode
branch
from
c763395 to
6c3b12c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contribution renames the internal strict mode flag in GTK from org.eclipse.swt.internal.gtk.enableStrictChecks to org.eclipse.swt.internal.enableStrictChecks and adds it to win32 to be used to check for correctly configured GCs for monitor-specific-scaling. The helps tracing invalid custom Drawables or GCs that are created with an invalid configuration.