Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the website for viash 0.8.2 #70

Merged
merged 26 commits into from
Feb 9, 2024
Merged

Update the website for viash 0.8.2 #70

merged 26 commits into from
Feb 9, 2024

Conversation

Grifs
Copy link
Contributor

@Grifs Grifs commented Dec 14, 2023

Rerendered pages for Viash 0.8.2

Probably need to think about how to better render the repository pages

Probably need to think about how to better render the repository pages
@Grifs Grifs requested a review from rcannood December 14, 2023 15:11
@Grifs Grifs changed the title 0 8 2 Update the website for viash 0.8.1 Dec 14, 2023
@Grifs Grifs changed the title Update the website for viash 0.8.1 Update the website for viash 0.8.2 Dec 14, 2023
Copy link

github-actions bot commented Dec 14, 2023

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-02-09 10:27 UTC

@rcannood
Copy link
Member

Agreed!

@tverbeiren
Copy link
Member

@DriesSchaumont @rcannood Could you take a look at the 'VDSL3 principles' page please?

Are you able to render it?

@rcannood
Copy link
Member

rcannood commented Feb 9, 2024

In the reference I noticed:

Screenshot from 2024-02-09 08-52-42

But I'd expect the repositories to be listed in its own /reference/config/functionality/repositories:

Screenshot from 2024-02-09 08-52-46


In addition, the .functionality.repositories documentation should link to the /reference/config/functionality/repositories page.

Screenshot from 2024-02-09 08-55-20


And the .functionality.dependencies[].repository should also link to the repository.

Screenshot from 2024-02-09 08-55-53


Is this still something that can be included for the 0.8.2 docs or is it a change that needs to happen at the level of Viash, and will thus be picked up in 0.8.4 or later?

@Grifs
Copy link
Contributor Author

Grifs commented Feb 9, 2024

Is this still something that can be included for the 0.8.2 docs or is it a change that needs to happen at the level of Viash, and will thus be picked up in 0.8.4 or later?

I guess we could fudge it in the build script, but ideally it would added on the side of Viash.
Additionally, the repositories page could use some love too.

@rcannood
Copy link
Member

rcannood commented Feb 9, 2024

I'm happy for the changes to be included in the upcoming release, as long as we don't forget about it ☺️ Does this work for you?

@Grifs
Copy link
Contributor Author

Grifs commented Feb 9, 2024

Absolutely. I'll do that next ;)

Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Grifs Grifs merged commit 005c2f6 into main Feb 9, 2024
1 check passed
@Grifs Grifs deleted the 0_8_2 branch February 9, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants