Merge pull request #459 from videogular/feat/unregister-media

feat(api): Add unregister media method to api
videogular · Mar 26, 2017 · 7ab6b56 · 7ab6b56
2 parents d77e506 + 352714f
commit 7ab6b56
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 4 deletions.
diff --git a/src/core/services/vg-api.spec.ts b/src/core/services/vg-api.spec.ts
@@ -328,4 +328,13 @@ describe('Videogular Player', () => {
 
         expect(api.medias['main']).toBe(media);
     });
+
+    it('Should register a new media object', () => {
+        let media = {id: 'main'};
+        api['main'] = {};
+
+        api.unregisterMedia(<IPlayable>media);
+
+        expect(api.medias['main']).toBe(undefined);
+    });
 });
diff --git a/src/core/services/vg-api.ts b/src/core/services/vg-api.ts
@@ -243,4 +243,8 @@ export class VgAPI {
     registerMedia(media:IPlayable) {
         this.medias[media.id] = media;
     }
+
+    unregisterMedia(media:IPlayable) {
+        delete this.medias[media.id];
+    }
 }
diff --git a/src/core/vg-media/vg-media.ts b/src/core/vg-media/vg-media.ts
@@ -73,10 +73,8 @@ export class VgMedia implements OnInit, OnDestroy, IPlayable {
             this.elem = this.vgMedia.elem;
         }
 
-        // It's not registered yet
-        if (!this.api.getMediaById(this.id)) {
-            this.api.registerMedia(this);
-        }
+        // Just in case we're creating this vgMedia dynamically register again into API
+        this.api.registerMedia(this);
 
         this.subscriptions = {
             // Native events
@@ -418,5 +416,7 @@ export class VgMedia implements OnInit, OnDestroy, IPlayable {
         this.timeUpdateObs.unsubscribe();
         this.volumeChangeObs.unsubscribe();
         this.errorObs.unsubscribe();
+
+        this.api.unregisterMedia(this);
     }
 }