Skip to content

Commit

Permalink
Merge pull request #240 from videogular/fix/types
Browse files Browse the repository at this point in the history
fix(types): Fix implicit any types
  • Loading branch information
Elecash authored Sep 21, 2016
2 parents aaab2d0 + 3448480 commit d07ffbb
Show file tree
Hide file tree
Showing 9 changed files with 27 additions and 27 deletions.
6 changes: 3 additions & 3 deletions src/services/vg-api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export class VgAPI {
}

getMasterMedia():IPlayable {
var master;
var master:any;
for (var id in this.medias) {
if (this.medias[id].isMaster === 'true' || this.medias[id].isMaster === true) {
master = this.medias[id];
Expand Down Expand Up @@ -164,7 +164,7 @@ export class VgAPI {

$$getAllProperties(property:string){
const medias = {};
let result;
let result:any;

for (var id in this.medias) {
//result[id] = this.medias[id][property];
Expand Down Expand Up @@ -206,7 +206,7 @@ export class VgAPI {
return result;
}

$$setAllProperties(property:string, value){
$$setAllProperties(property:string, value:any){
for (var id in this.medias) {
this.medias[id][property] = value;
}
Expand Down
4 changes: 2 additions & 2 deletions src/services/vg-fullscreen-api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export class VgFullscreenAPI {
}
}

static request(elem) {
static request(elem:any) {
if (!elem) elem = this.videogularElement;

this.isFullscreen = true;
Expand All @@ -113,7 +113,7 @@ export class VgFullscreenAPI {
}
}

static enterElementInFullScreen(elem) {
static enterElementInFullScreen(elem:any) {
elem[this.polyfill.request]();
}

Expand Down
2 changes: 1 addition & 1 deletion src/vg-buffering/vg-buffering.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ export class VgBuffering {

constructor(ref:ElementRef, public API: VgAPI) {
this.elem = ref.nativeElement;
API.playerReadyEvent.subscribe((api) => this.onPlayerReady());
API.playerReadyEvent.subscribe((api:VgAPI) => this.onPlayerReady());
this.bufferCheck = this.bufferCheck.bind(this);
}

Expand Down
2 changes: 1 addition & 1 deletion src/vg-controls/vg-abstract-control.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {VgAPI} from "../services/vg-api";

export class VgAbstractControl {
constructor(api:VgAPI) {
api.playerReadyEvent.subscribe((api) => this.onPlayerReady());
api.playerReadyEvent.subscribe((api:VgAPI) => this.onPlayerReady());
}

onPlayerReady() {
Expand Down
2 changes: 1 addition & 1 deletion src/vg-controls/vg-controls.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export class VgControls extends VgAbstractControl {
@Input('autohide') autohide:boolean = false;
@Input('autohide-time') autohideTime:number = 3;

private timer:number;
private timer:any;

constructor(private API:VgAPI, private ref:ElementRef) {
super(API);
Expand Down
2 changes: 1 addition & 1 deletion src/vg-controls/vg-scrub-bar/vg-scrub-bar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export class VgScrubBar extends VgAbstractControl {
this.target = this.API.getMediaById(this.vgFor);
}

onMouseDownScrubBar($event) {
onMouseDownScrubBar($event:any) {
var percentage = $event.offsetX * 100 / this.elem.scrollWidth;

this.target.seekTime(percentage, true);
Expand Down
6 changes: 3 additions & 3 deletions src/vg-cue-points/vg-cue-points.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export class VgCuePoints {
onLoad.subscribe(this.onLoad.bind(this));
}

onLoad(event) {
onLoad(event:any) {
var cues = event.target.track.cues;

this.ref.nativeElement.cues = cues;
Expand All @@ -34,11 +34,11 @@ export class VgCuePoints {
}
}

onEnter(event) {
onEnter(event:any) {
this.onEnterCuePoint.next(event.target);
}

onExit(event) {
onExit(event:any) {
this.onExitCuePoint.next(event.target);
}
}
28 changes: 14 additions & 14 deletions src/vg-media/vg-media.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export class VgMedia implements OnInit, IPlayable {
endAds: Observable.fromEvent(<any>window, VgEvents.VG_END_ADS),
// See changes on <source> child elements to reload the video file
mutation: Observable.create(
(observer) => {
(observer:any) => {
let domObs = new MutationObserver((mutations) => {
observer.next(mutations);
});
Expand Down Expand Up @@ -83,7 +83,7 @@ export class VgMedia implements OnInit, IPlayable {
this.subscriptions.error.subscribe(this.onError.bind(this));
}

onMutation(mutations) {
onMutation(mutations:any) {
this.elem.pause();
this.elem.currentTime = 0;

Expand Down Expand Up @@ -136,42 +136,42 @@ export class VgMedia implements OnInit, IPlayable {
return this.elem.buffered;
}

onCanPlay(event) {
onCanPlay(event:any) {
this.canPlay = true;
}

onCanPlayThrough(event) {
onCanPlayThrough(event:any) {
this.canPlayThrough = true;
}

onLoadMetadata(event) {
onLoadMetadata(event:any) {
this.isMetadataLoaded = true;

this.time.total = this.duration * 1000;
}

onWait(event) {
onWait(event:any) {
this.isWaiting = true;
}

onComplete(event) {
onComplete(event:any) {
this.isCompleted = true;
this.state = VgStates.VG_ENDED;
}

onStartPlaying(event) {
onStartPlaying(event:any) {
this.state = VgStates.VG_PLAYING;
}

onPlay(event) {
onPlay(event:any) {
this.state = VgStates.VG_PLAYING;
}

onPause(event) {
onPause(event:any) {
this.state = VgStates.VG_PAUSED;
}

onTimeUpdate(event) {
onTimeUpdate(event:any) {
var end = this.buffered.length - 1;

this.time.current = this.currentTime * 1000;
Expand All @@ -182,19 +182,19 @@ export class VgMedia implements OnInit, IPlayable {
}
}

onProgress(event) {
onProgress(event:any) {
var end = this.buffered.length - 1;

if (end >= 0) {
this.buffer.end = this.buffered.end(end) * 1000;
}
}

onVolumeChange(event) {
onVolumeChange(event:any) {
// TODO: Save to localstorage the current volume
}

onError(event) {
onError(event:any) {
// TODO: Handle error messages
}
}
2 changes: 1 addition & 1 deletion src/vg-player/vg-player.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export class VgPlayer implements AfterContentInit {
VgFullscreenAPI.onChangeFullscreen.subscribe(this.onChangeFullscreen.bind(this));
}

onChangeFullscreen(fsState) {
onChangeFullscreen(fsState:boolean) {
if (!VgFullscreenAPI.nativeFullscreen) {
this.isFullscreen = fsState;
this.zIndex = fsState ? VgUtils.getZIndex().toString() : 'auto';
Expand Down

0 comments on commit d07ffbb

Please sign in to comment.