feat: [Pallet Pass] Configuration extensions #19
Annotations
9 warnings
the borrowed expression implements the required traits:
pallets/pass/src/lib.rs#L295
warning: the borrowed expression implements the required traits
--> pallets/pass/src/lib.rs:295:57
|
295 | let (account_id, until) = Sessions::<T, I>::get(&who)?;
| ^^^^ help: change this to: `who`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
using `map_err` over `inspect_err`:
pallets/pass/src/lib.rs#L83
warning: using `map_err` over `inspect_err`
--> pallets/pass/src/lib.rs:83:15
|
83 | #[pallet::pallet]
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
= note: `#[warn(clippy::manual_inspect)]` on by default
help: try
|
83 - #[pallet::pallet]
83 + #[pallet::&inspect_err]
|
|
matching on `Some` with `ok()` is redundant:
pallets/pass/src/lib.rs#L157
warning: matching on `Some` with `ok()` is redundant
--> pallets/pass/src/lib.rs:157:17
|
157 | if let Some(account_id) = Pallet::<T, I>::account_id_for(credential.user_id()).ok() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok
= note: `#[warn(clippy::match_result_ok)]` on by default
help: consider matching on `Ok(account_id)` and removing the call to `ok` instead
|
157 | if let Ok(account_id) = Pallet::<T, I>::account_id_for(credential.user_id()) {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
this expression creates a reference which is immediately dereferenced by the compiler:
pallets/pass/src/extension.rs#L88
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> pallets/pass/src/extension.rs:88:59
|
88 | let who = Pallet::<T, I>::signer_from_session_key(&who).unwrap_or(who.clone());
| ^^^^ help: change this to: `who`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
pallets/pass/src/extension.rs#L77
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> pallets/pass/src/extension.rs:77:59
|
77 | let who = Pallet::<T, I>::signer_from_session_key(&who).unwrap_or(who.clone());
| ^^^^ help: change this to: `who`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
using `map_err` over `inspect_err`:
pallets/referenda-tracks/src/lib.rs#L93
warning: using `map_err` over `inspect_err`
--> pallets/referenda-tracks/src/lib.rs:93:15
|
93 | #[pallet::pallet]
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
= note: `#[warn(clippy::manual_inspect)]` on by default
help: try
|
93 - #[pallet::pallet]
93 + #[pallet::&inspect_err]
|
|
using `map_err` over `inspect_err`:
pallets/template/src/lib.rs#L34
warning: using `map_err` over `inspect_err`
--> pallets/template/src/lib.rs:34:15
|
34 | #[pallet::pallet]
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
= note: `#[warn(clippy::manual_inspect)]` on by default
help: try
|
34 - #[pallet::pallet]
34 + #[pallet::&inspect_err]
|
|
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
clippy
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|