Merge branch 'virtual-kubelet:master' into cluster_role_fix

virtual-kubelet · Jun 13, 2024 · f07cc72 · f07cc72
2 parents 85bbd71 + 3fb3b5d
commit f07cc72
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 6 deletions.
diff --git a/.github/workflows/create-release-pull-request.yml b/.github/workflows/create-release-pull-request.yml
@@ -38,7 +38,7 @@ jobs:
         env:
           VERSION: "${{ github.event.inputs.release_version }}"
       - name: Create release pull request
-        uses: peter-evans/create-pull-request@v5
+        uses: peter-evans/create-pull-request@v6
         with:
           commit-message: "release: update manifest and helm charts for ${{ github.event.inputs.release_version }}"
           title: "release: update manifest and helm charts for ${{ github.event.inputs.release_version }}"

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -45,7 +45,7 @@ jobs:
           make unit-tests
 
       - name: Upload Codecov report
-        uses: codecov/codecov-action@v3
+        uses: codecov/codecov-action@v4
         with:
           ## Comma-separated list of files to upload
           files: ./coverage.txt
diff --git a/charts/virtual-kubelet/README.md b/charts/virtual-kubelet/README.md
@@ -60,10 +60,10 @@ The following table lists the configurable parameters of the azure-aci chart and
 | image.repository                               | Image repository.                                                                                                     | `mcr.microsoft.com`                   |
 | image.name                                     | Image name.                                                                                                           | `oss/virtual-kubelet/virtual-kubelet` |
 | image.tag                                      | Image release version/tag.                                                                                            | `latest`                              |
-| image.pullPolicy                               | Image pull policy.                                                                                                    | `Always`                              | 
+| image.pullPolicy                               | Image pull policy.                                                                                                    | `IfNotPresent`                              | 
 | initImage.name                                 | Init container image name.                                                                                            | `oss/virtual-kubelet/init-validation` |
 | initImage.initTag                              | Init container image release version/tag.                                                                             | `0.2.0`                               |
-| initImage.pullPolicy                           | Init container image pull policy.                                                                                     | `Always`                              |
+| initImage.pullPolicy                           | Init container image pull policy.                                                                                     | `IfNotPresent`                              |
 | nodeName                                       | The node name that will be assigned to be the VK one.                                                                 | `virtual-node-aci-linux-helm`         |
 | nodeOsType                                     | The node/VM type. Values should be `Windows` or `Linux`.                                                              | `Linux`                               |
 | monitoredNamespace                             | Kubernetes namespace. default values means monitor `all`                                                              | `""`                                  |

diff --git a/charts/virtual-kubelet/templates/deployment.yaml b/charts/virtual-kubelet/templates/deployment.yaml
@@ -21,6 +21,10 @@ spec:
         - name: init-validation
           image: "{{ .Values.initImage.repository }}/{{ .Values.initImage.name }}:{{ .Values.initImage.initTag }}"
           imagePullPolicy: {{ .Values.initImage.pullPolicy }}
+          securityContext:
+            capabilities:
+              drop:
+              - ALL
           env:
           - name: KUBELET_PORT
             value: "10250"
@@ -111,6 +115,10 @@ spec:
       - name: {{ template "vk.fullname" . }}
         image: "{{ .Values.image.repository }}/{{ .Values.image.name }}:{{ .Values.image.tag }}"
         imagePullPolicy: {{ .Values.image.pullPolicy }}
+        securityContext:
+          capabilities:
+            drop:
+            - ALL
         env:
         - name: KUBELET_PORT
           value: "10250"

diff --git a/charts/virtual-kubelet/values.yaml b/charts/virtual-kubelet/values.yaml
@@ -3,13 +3,13 @@ image:
   repository: mcr.microsoft.com
   name: oss/virtual-kubelet/virtual-kubelet
   tag: 1.6.1
-  pullPolicy: Always
+  pullPolicy: IfNotPresent
 
 initImage:
   repository: mcr.microsoft.com
   name: oss/virtual-kubelet/init-validation
   initTag: 0.2.0
-  pullPolicy: Always
+  pullPolicy: IfNotPresent
 
 namespace: vk-azure-aci