Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding additional aci supported regions and fixing security alert #11 #587

Closed
wants to merge 15 commits into from
Closed

feat: adding additional aci supported regions and fixing security alert #11 #587

wants to merge 15 commits into from

Conversation

smritidahal653
Copy link
Collaborator

@smritidahal653 smritidahal653 commented Dec 11, 2023 •
edited
Loading

@smritidahal653 smritidahal653 changed the title adding back chinaeast2 region in the supported list feat: adding back chinaeast2 region in the supported list Dec 11, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 11, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8db4813) 69.81% compared to head (f764e30) 69.81%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #587   +/-   ##
=======================================
  Coverage   69.81%   69.81%           
=======================================
  Files          15       15           
  Lines        2597     2597           
=======================================
  Hits         1813     1813           
  Misses        666      666           
  Partials      118      118

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smritidahal653 smritidahal653 changed the title feat: adding back chinaeast2 region in the supported list feat: adding mc regions to supported regions list and fixing security alert #11 Dec 11, 2023
@smritidahal653 smritidahal653 changed the title feat: adding mc regions to supported regions list and fixing security alert #11 feat: adding additional aci supported regions and fixing security alert #11 Dec 19, 2023
@smritidahal653 smritidahal653 deleted the smriti_aci_regions branch January 22, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fei-Guo Fei-Guo Fei-Guo approved these changes

@helayoty helayoty Awaiting requested review from helayoty helayoty is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smritidahal653 @Fei-Guo