Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update ACI regions #589

Merged
merged 44 commits into from
Jan 20, 2024
Merged

feat: Update ACI regions #589

Show file tree
Hide file tree
Changes from 41 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
0b73e57
new aci regions
smritidahal653 Jan 10, 2024
4008dcf
updating exec command
smritidahal653 Jan 10, 2024
fe4642b
adding logs from aci pod for debugging
smritidahal653 Jan 10, 2024
e46bf15
updating log output
smritidahal653 Jan 11, 2024
625e1b2
removing deprecated selector
smritidahal653 Jan 11, 2024
dab3b5a
updating ubuntu version
smritidahal653 Jan 11, 2024
be2bcad
installing kubectl binary in e2e workflows
smritidahal653 Jan 16, 2024
49c3a07
addressing PR comments
smritidahal653 Jan 16, 2024
a1ef032
upgrading azure-login to v 1.6.0
smritidahal653 Jan 16, 2024
98bc7de
changing azure login version to 1.5
smritidahal653 Jan 17, 2024
f787d52
updating azure login version to 1.5
smritidahal653 Jan 17, 2024
91ad969
updating e2e.yaml
smritidahal653 Jan 17, 2024
3e3c2a1
upgrading azure login version
smritidahal653 Jan 17, 2024
b0b76b3
updating workflow files
smritidahal653 Jan 17, 2024
7683015
updating yml files
smritidahal653 Jan 17, 2024
2b1b1d2
update yml
smritidahal653 Jan 17, 2024
d72dba7
adding creds
smritidahal653 Jan 17, 2024
edb94d2
updating creds
smritidahal653 Jan 17, 2024
4af40e8
fixing creds
smritidahal653 Jan 17, 2024
0778c9d
adding env to all jobs
smritidahal653 Jan 17, 2024
b0923e3
ci: Fix e2e pipelines (#592)
helayoty Jan 18, 2024
483e3c1
updating ubuntu version
smritidahal653 Jan 11, 2024
8dc5030
upgrading azure-login to v 1.6.0
smritidahal653 Jan 16, 2024
f1d1710
changing azure login version to 1.5
smritidahal653 Jan 17, 2024
d408823
updating azure login version to 1.5
smritidahal653 Jan 17, 2024
10fab50
updating e2e.yaml
smritidahal653 Jan 17, 2024
733d9d9
upgrading azure login version
smritidahal653 Jan 17, 2024
d756651
updating creds
smritidahal653 Jan 17, 2024
0d664e4
fixing e2e.yml
smritidahal653 Jan 17, 2024
d350261
increasing timeout
smritidahal653 Jan 17, 2024
b136c1d
testing without exec
smritidahal653 Jan 17, 2024
4783cd1
Merge branch 'master' into new_aci_regions
smritidahal653 Jan 18, 2024
5faface
fixing e2e.yml
smritidahal653 Jan 17, 2024
c2dc157
updating VK dependency to v1.11.0
smritidahal653 Jan 19, 2024
7edf410
un-commenting failing test cases
smritidahal653 Jan 19, 2024
80ebecd
cleanup
smritidahal653 Jan 19, 2024
4441c06
fix: security fix 11 & vk upgrade to v1.11.0 (#590)
smritidahal653 Jan 19, 2024
a9f89aa
addressing PR comments
smritidahal653 Jan 16, 2024
ca87320
updating workflow files
smritidahal653 Jan 17, 2024
2e8bbfc
adding new line
smritidahal653 Jan 19, 2024
8e27d42
Merge branch 'master' into new_aci_regions
smritidahal653 Jan 19, 2024
ebcbee9
cleanup
smritidahal653 Jan 19, 2024
a9483d8
Merge branch 'master' into new_aci_regions
smritidahal653 Jan 19, 2024
3961e52
cleanup
smritidahal653 Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/aks-addon-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,4 @@ jobs:
if: ${{ always() }}
run: |
set +e
az group delete --name "${{ env.CLUSTER_NAME }}" --yes --no-wait || true
az group delete --name "${{ env.CLUSTER_NAME }}" --yes --no-wait || true
smritidahal653 marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion .github/workflows/e2e-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,4 +75,4 @@ jobs:
if: ${{ always() }}
run: |
set +e
az group delete --name "${{ env.CLUSTER_NAME }}" --yes --no-wait || true
az group delete --name "${{ env.CLUSTER_NAME }}" --yes --no-wait || true
smritidahal653 marked this conversation as resolved.
Show resolved Hide resolved
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,15 +105,15 @@ e2e-test:
IMG_URL=$(REGISTRY) IMG_REPO=$(IMG_NAME) IMG_TAG=$(IMG_TAG) \
INIT_IMG_REPO=$(INIT_IMG_NAME) INIT_IMG_TAG=$(INIT_IMG_TAG) \
LOCATION=$(LOCATION) RESOURCE_GROUP=$(E2E_CLUSTER_NAME) \
$(AKS_E2E_SCRIPT) go test -timeout 60m -v ./e2e
$(AKS_E2E_SCRIPT) go test -timeout 90m -v ./e2e

.PHONY: aks-addon-e2e-test
aks-addon-e2e-test:
PR_RAND=$(PR_COMMIT_SHA) E2E_TARGET=$(E2E_TARGET) \
IMG_URL=$(REGISTRY) IMG_REPO=$(IMG_NAME) IMG_TAG=$(IMG_TAG) \
INIT_IMG_REPO=$(INIT_IMG_NAME) INIT_IMG_TAG=$(INIT_IMG_TAG) \
LOCATION=$(LOCATION) RESOURCE_GROUP=$(E2E_CLUSTER_NAME) \
$(AKS_ADDON_E2E_SCRIPT) go test -timeout 60m -v ./e2e
$(AKS_ADDON_E2E_SCRIPT) go test -timeout 90m -v ./e2e

.PHONY: vet
vet:
Expand Down
2 changes: 1 addition & 1 deletion e2e/volume_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ func TestPodWithMultiVolume(t *testing.T) {
}
t.Log("success create pod with multi-volume")

cmd = kubectl("exec", "pod/vk-e2e-volume", "--namespace=vk-test", "--", "ls /var/run/secrets/kubernetes.io/serviceaccount")
cmd = kubectl("exec", "pod/vk-e2e-volume", "-c", "hpa-example", "--namespace=vk-test", "--", "ls /var/run/secrets/kubernetes.io/serviceaccount")
helayoty marked this conversation as resolved.
Show resolved Hide resolved
out, err := cmd.CombinedOutput()
if err != nil {
t.Fatal(string(out))
Expand Down
13 changes: 13 additions & 0 deletions pkg/provider/aci.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,8 @@ type AuthConfig struct {

// See https://learn.microsoft.com/en-us/azure/container-instances/container-instances-region-availability
var validAciRegions = []string{
"australiacentral",
"australiacentral2",
"australiaeast",
"australiasoutheast",
"brazilsouth",
Expand All @@ -128,21 +130,32 @@ var validAciRegions = []string{
"centralindia",
"centralus",
"centraluseuap",
"chinaeast2",
"chinaeast3",
"chinanorth3",
"eastasia",
"eastus",
"eastus2",
"eastus2euap",
"francecentral",
"francesouth",
"germanynorth",
"germanywestcentral",
"japaneast",
"japanwest",
"jioindiawest",
"israelcentral",
"italynorth",
"koreacentral",
"koreasouth",
"northcentralus",
"northeurope",
"norwayeast",
"norwaywest",
"polandcentral",
"qatarcentral",
"southafricanorth",
"southafricawest",
"southcentralus",
"southindia",
"southeastasia",
Expand Down
Loading