Fix double attach on single http serve mux.

virtual-kubelet · Aug 13, 2020 · 49763f5 · 49763f5
1 parent d9f54a5
commit 49763f5
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/internal/commands/root/http.go b/internal/commands/root/http.go
@@ -96,16 +96,11 @@ func setupHTTPServer(ctx context.Context, p provider.Provider, cfg *apiServerCon
 			StreamIdleTimeout:     cfg.StreamIdleTimeout,
 			StreamCreationTimeout: cfg.StreamCreationTimeout,
 		}
-		api.AttachPodRoutes(podRoutes, mux, true)
 
-		var summaryHandlerFunc api.PodStatsSummaryHandlerFunc
 		if mp, ok := p.(provider.PodMetricsProvider); ok {
-			summaryHandlerFunc = mp.GetStatsSummary
-		}
-		podMetricsRoutes := api.PodMetricsConfig{
-			GetStatsSummary: summaryHandlerFunc,
+			podRoutes.GetStatsSummary = mp.GetStatsSummary
 		}
-		api.AttachPodMetricsRoutes(podMetricsRoutes, mux)
+		api.AttachPodRoutes(podRoutes, mux, true)
 
 		s := &http.Server{
 			Handler:   mux,