Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cpack config for NPM build #73

Merged
merged 42 commits into from
Dec 15, 2023

Conversation

vishniakov-nikolai
Copy link
Owner

Details:

  • item1
  • ...

Tickets:

  • ticket-id

cmake/developer_package/packaging/npm.cmake Outdated Show resolved Hide resolved
include(GNUInstallDirs)

# Put all libraries in one dir
set(CMAKE_SKIP_INSTALL_RPATH OFF)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the comment is wrong

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment was fixed

cmake/packaging/npm.cmake Outdated Show resolved Hide resolved
src/bindings/js/node/CMakeLists.txt Outdated Show resolved Hide resolved
src/bindings/js/node/CMakeLists.txt Outdated Show resolved Hide resolved
@vishniakov-nikolai vishniakov-nikolai mentioned this pull request Dec 13, 2023
@vishniakov-nikolai vishniakov-nikolai changed the base branch from feature/cmake-build to js-wasm-proto December 13, 2023 17:05
@vishniakov-nikolai vishniakov-nikolai requested review from ilya-lavrenov and almilosz and removed request for ilya-lavrenov December 14, 2023 15:39
@vishniakov-nikolai vishniakov-nikolai merged commit 7a57b12 into js-wasm-proto Dec 15, 2023
15 of 25 checks passed
@vishniakov-nikolai vishniakov-nikolai deleted the feature/extend-cpack branch December 15, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants