fixed the log4j security issues #126
Conversation
There was a problem hiding this comment.
This file should probably be excluded or do we really need it?
There was a problem hiding this comment.
The same applies to the generated code in src-gen, do we really need that in the repo?
There was a problem hiding this comment.
The Maven build generates all files to the target folder and the remaining steps of the build (e.g., Java compiler) only pick up files from there. We can add the directories to the .gitignore file, but there is really no point in using them, unless the entire build is done by Eclipse.
There was a problem hiding this comment.
xtend-gen should probably also be excluded
| checkState(correspondencesResource != null, "Correspondences resource must be specified to load existing correspondences"); | ||
| Resource loadedResource = loadOrCreateResource(withGlobalFactories(new ResourceSetImpl()), correspondencesResource.getURI()); | ||
| checkState(correspondencesResource != null, | ||
| "Correspondences resource must be specified to load existing correspondences"); |
There was a problem hiding this comment.
Please don't check in formatting changes or use a dedicated PR for them.
There was a problem hiding this comment.
wasn't my intention, sorry
|
No description provided.