Federation domain issuer must be https url #2167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pinniped-dev canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2167 +/- ##
==========================================
- Coverage 31.96% 31.94% -0.03%
==========================================
Files 379 379
Lines 62113 62084 -29
==========================================
- Hits 19857 19833 -24
+ Misses 41726 41720 -6
- Partials 530 531 +1 ☔ View full report in Codecov by Sentry. |
joshuatcasey
force-pushed
the
jtc/federation-domain-issuer-must-be-https-url
branch
6 times, most recently
from
594cb8f to
c0c88e1
Compare
cfryanr
reviewed
Jan 2, 2025
cfryanr
reviewed
Jan 2, 2025
|
Just pushed
|
|
Also fixes #468 |
joshuatcasey
force-pushed
the
jtc/federation-domain-issuer-must-be-https-url
branch
2 times, most recently
from
d689abc to
8eb093d
Compare
|
Wait on #2182 to rebase this PR, since CI failed due to a CI flake (https://ci.pinniped.dev/teams/main/pipelines/pull-requests/jobs/build-test-image/builds/200) |
… for old K8s versions
joshuatcasey
force-pushed
the
jtc/federation-domain-issuer-must-be-https-url
branch
from
8eb093d to
1d873be
Compare
cfryanr
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Federation domain issuer must be https url