Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Remove glibc dependency long term #477

Conversation

xinyanw409
Copy link
Contributor

@xinyanw409 xinyanw409 commented Jun 28, 2022

What this PR does / why we need it:
This PR tends to spin data-manager binary into two different ones, install and server. In this way both vsphere plugin image and backup-driver image can get rid of dependency of glibc.
Which issue(s) this PR fixes:

Fixes #466

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@xinyanw409 xinyanw409 marked this pull request as draft June 28, 2022 17:39
@svcbot-qecnsdp
Copy link

Sorry, some of the pre-check tests are failing for this PR !

Please check the Jenkins job for more details
https://container-dp.svc.eng.vmware.com/job/CNSDP-CI/743/

@svcbot-qecnsdp
Copy link

Sorry, some of the pre-check tests are failing for this PR !

Please check the Jenkins job for more details
https://container-dp.svc.eng.vmware.com/job/CNSDP-CI/744/

@xinyanw409 xinyanw409 force-pushed the remove-glibc-dependency-long-term branch 2 times, most recently from 35f0376 to 642a208 Compare November 7, 2022 23:17
@svcbot-qecnsdp
Copy link

Sorry, some of the pre-check tests are failing for this PR !

Please check the Jenkins job for more details
https://container-dp.svc.eng.vmware.com/job/CNSDP-CI/755/

@xinyanw409 xinyanw409 force-pushed the remove-glibc-dependency-long-term branch from 642a208 to 33e54e8 Compare November 7, 2022 23:18
@svcbot-qecnsdp
Copy link

Sorry, some of the pre-check tests are failing for this PR !

Please check the Jenkins job for more details
https://container-dp.svc.eng.vmware.com/job/CNSDP-CI/756/

@ywk253100
Copy link

@xinyanw409 The vsphere-plugin itself depends on github.com/vmware/virtual-disks which needs glibc:

go mod why -m github.com/vmware/virtual-disks
# github.com/vmware/virtual-disks
github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/ivd
github.com/vmware/virtual-disks/pkg/disklib

https://github.com/vmware-tanzu/velero-plugin-for-vsphere/blob/main/cmd/velero-plugin-for-vsphere/main.go#L25

"github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/snapshotmgr"

"github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/ivd"

So the dependency should be removed to make sure vsphere-plugin can run in an environment that has no glibc.

Correct me if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to remove the dependency for glibc inside the Velero image
3 participants