Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable docker push image in ci. #556

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Disable docker push image in ci. #556

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a61a98
Disable docker push image in ci.
lipingxue Nov 1, 2023
54c5367
Address comments from Xing.
lipingxue Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,12 @@ jobs:
run: |
cd src/github.com/vmware-tanzu/velero-plugin-for-vsphere
make ci
- name: Build the plugin and push images to docker hub
if: github.event_name == 'push' && github.repository == 'vmware-tanzu/velero-plugin-for-vsphere'
env:
GOPATH: ${GITHUB_WORKSPACE}
run: |
cd src/github.com/vmware-tanzu/velero-plugin-for-vsphere
echo ${{ secrets.DOCKERHUB_PASSWORD }} | docker login -u ${{ secrets.DOCKERHUB_USERNAME }} --password-stdin
make push
# The following code are commented out because push image will fail due to invalid username/password for docker hub
#- name: Build the plugin and push images to docker hub
lipingxue marked this conversation as resolved.
Show resolved Hide resolved
# if: github.event_name == 'push' && github.repository == 'vmware-tanzu/velero-plugin-for-vsphere'
# env:
# GOPATH: ${GITHUB_WORKSPACE}
# run: |
# cd src/github.com/vmware-tanzu/velero-plugin-for-vsphere
# echo ${{ secrets.DOCKERHUB_PASSWORD }} | docker login -u ${{ secrets.DOCKERHUB_USERNAME }} --password-stdin
# make push