-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick changes to release-1.5 branch. #570
Merged
lipingxue
merged 8 commits into
vmware-tanzu:release-1.5
from
lipingxue:lipingx-release-1.5.3
Mar 11, 2024
Merged
Cherry-pick changes to release-1.5 branch. #570
lipingxue
merged 8 commits into
vmware-tanzu:release-1.5
from
lipingxue:lipingx-release-1.5.3
Mar 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepakkinni
approved these changes
Mar 11, 2024
Signed-off-by: Liping Xue <[email protected]>
* Document change. Signed-off-by: Liping Xue <[email protected]> * Address comment from Xing. Signed-off-by: Liping Xue <[email protected]> * Remove files that are not needed for this change. Signed-off-by: Liping Xue <[email protected]> --------- Signed-off-by: Liping Xue <[email protected]>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.17.0. - [Commits](golang/crypto@v0.14.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Liping Xue <[email protected]>
Signed-off-by: Liping Xue <[email protected]>
…acters (vmware-tanzu#564) * Signed-off-by: Varun Srinivasan <[email protected]> Create common config and new function to parse config data * Always populate "port" key of parameters map after setting default VC port if config port value is empty Signed-off-by: Varun Srinivasan <[email protected]> * Clean up test logging and unit tests Signed-off-by: Varun Srinivasan <[email protected]> * Keep only necessary config values Signed-off-by: Varun Srinivasan <[email protected]> * Refactor ParseConfig to return error for sanitized error handling Signed-off-by: Varun Srinivasan <[email protected]> --------- Signed-off-by: Varun Srinivasan <[email protected]> Signed-off-by: Liping Xue <[email protected]>
…e-tanzu#565) * Only skip PVC creation if --namespace-mapping flag is not used Signed-off-by: Varun Srinivasan <[email protected]> * Refactor SkipPVCCreation function signature to add target namespace as a parameter Signed-off-by: Varun Srinivasan <[email protected]> --------- Signed-off-by: Varun Srinivasan <[email protected]> Signed-off-by: Liping Xue <[email protected]>
Signed-off-by: xing-yang <[email protected]> Signed-off-by: Liping Xue <[email protected]>
…onsumer volumeBindingMode (vmware-tanzu#568) Signed-off-by: Deepak Kinni <[email protected]> Co-authored-by: Deepak Kinni <[email protected]> Signed-off-by: Liping Xue <[email protected]>
lipingxue
force-pushed
the
lipingx-release-1.5.3
branch
from
March 11, 2024 18:38
417508a
to
fe975ef
Compare
Lgtm |
xing-yang
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Cherry-pick changes #559 #560 #562 #564 #565 #566 #567 #568 to release-1.5 branch.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: