Add noctx linter.

Signed-off-by: Xun Jiang <[email protected]>
vmware-tanzu · Nov 29, 2023 · ec03d1e · ec03d1e
1 parent dbd1a12
commit ec03d1e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/golangci.yaml b/golangci.yaml
@@ -330,6 +330,7 @@ linters:
     - errchkjson
     - ginkgolinter
     - nilerr
+    - noctx
   fast: false
 
 

diff --git a/pkg/cmd/util/downloadrequest/downloadrequest.go b/pkg/cmd/util/downloadrequest/downloadrequest.go
@@ -123,7 +123,7 @@ func Stream(ctx context.Context, kbClient kbclient.Client, namespace, name strin
 		ExpectContinueTimeout: defaultTransport.ExpectContinueTimeout,
 	}
 
-	httpReq, err := http.NewRequest(http.MethodGet, created.Status.DownloadURL, nil)
+	httpReq, err := http.NewRequestWithContext(ctx, http.MethodGet, created.Status.DownloadURL, nil)
 	if err != nil {
 		return err
 	}
-Original file line number
+Diff line change
@@ Expand Up / @@ -330,6 +330,7 @@ linters: @@
         - errchkjson
         - ginkgolinter
         - nilerr
+        - noctx
       fast: false
@@ Expand Down @@