Handle update conflict when restoring the status

Handle update conflict when restoring the status Fixes #8184 Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
vmware-tanzu · Jan 21, 2025 · f0efe2a · f0efe2a
1 parent 223e1fc
commit f0efe2a
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 5 deletions.
diff --git a/changelogs/unreleased/8630-ywk253100 b/changelogs/unreleased/8630-ywk253100
@@ -0,0 +1 @@
+Handle update conflict when restoring the status
diff --git a/pkg/restore/restore.go b/pkg/restore/restore.go
@@ -48,6 +48,7 @@ import (
 	"k8s.io/client-go/dynamic/dynamicinformer"
 	corev1 "k8s.io/client-go/kubernetes/typed/core/v1"
 	"k8s.io/client-go/tools/cache"
+	"k8s.io/client-go/util/retry"
 	crclient "sigs.k8s.io/controller-runtime/pkg/client"
 
 	"github.com/vmware-tanzu/velero/internal/credentials"
@@ -1669,13 +1670,26 @@ func (ctx *restoreContext) restoreItem(obj *unstructured.Unstructured, groupReso
 			errs.Add(namespace, err)
 			return warnings, errs, itemExists
 		}
-		obj.SetResourceVersion(createdObj.GetResourceVersion())
-		updated, err := resourceClient.UpdateStatus(obj, metav1.UpdateOptions{})
-		if err != nil {
+
+		resourceVersion := createdObj.GetResourceVersion()
+		if err := retry.RetryOnConflict(retry.DefaultRetry, func() error {
+			obj.SetResourceVersion(resourceVersion)
+			updated, err := resourceClient.UpdateStatus(obj, metav1.UpdateOptions{})
+			if err != nil {
+				if apierrors.IsConflict(err) {
+					res, err := resourceClient.Get(name, metav1.GetOptions{})
+					if err == nil {
+						resourceVersion = res.GetResourceVersion()
+					}
+				}
+				return err
+			}
+
+			createdObj = updated
+			return nil
+		}); err != nil {
 			ctx.log.Infof("status field update failed %s: %v", kube.NamespaceAndName(obj), err)
 			warnings.Add(namespace, err)
-		} else {
-			createdObj = updated
 		}
 	}
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Handle update conflict when restoring the status