Revert PR #6907 as site is not deploying

[OrlinVasilev]

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

• Accepted the DCO. Commits without the DCO will delay acceptance.
• Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
• Updated the corresponding documentation in site/content/docs/main.

[kaovilai]

https://deploy-preview-6980--velero.netlify.app/docs/v1.12/ did deploy

[OrlinVasilev]

https://deploy-preview-6981--velero.netlify.app/

[kaovilai]

can you publish your netlify settings?

[OrlinVasilev]

[kaovilai]

also env

[OrlinVasilev]

[kaovilai]

Can you unset everything like so?

That way the toml is the source of truth.

Otherwise commit the build settings to site building doc

[OrlinVasilev]

The new netlify white theme is so bad :)

[kaovilai]

I think having it be all in toml would be best for other collaborators to contribute.. if unsetting the config in netlify settings fixes it.

[kaovilai]

So basically what you have in #6981 (comment)
was not settable when I asked in netlify forums. Netlify UI was broken as I noted in https://answers.netlify.com/t/deploy-did-not-succeed-deploy-directory-site-site-public-does-not-exist/103160/3?u=kaovilai

Hence I had to exclusively use the toml to set the right path. Netlify staff verified my toml was good.

[OrlinVasilev]

the settings on the Netlify deployment sections are overwritten by the netlify.toml anyway

Not sure why Netlify folks stated that it's OKI guess misunderstanding, but it was wrong as we check-out in /opt/build/repo/ and then we build from site and we deploy from site/public.

The current settings are not working for the last 2 weeks

[kaovilai]

What I have works today.

You will note that the package directory is not being overwritten.

[kaovilai]

In any case.. the bug (netlify UI) I reported which prevented this setting from being set was fixed... so we can go ahead with this PR and I will have to set package directory in the netlify UI.

Should add the settings here to the doc tho..

Without the knowledge of velero (netlify ui) build settings here it basically doesn't build prior to #6907

[kaovilai]

Can you at least unset the package directory and trigger a build to try prior to merging?

Package directory
the directory that contains your site files, including the netlify.toml. Set this value only if it is different from the base directory.

netlify.toml is cleary not in site/ as set here

[kaovilai]

You can trigger by going to https://app.netlify.com/sites/velero/deploys

[kaovilai]

You'd have to unset base directory in UI to unset package directory

[OrlinVasilev]

here you go ! https://6531550e78c95b3eaacf6de1--velero.netlify.app/docs/main/file-system-backup/

[kaovilai]

woot!

[kaovilai]

https://app.netlify.com/sites/velero/deploys/6531550e78c95b3eaacf6de1 looks like a deploy for this PR
I didn't mean deploy for this PR.. I mean deploy of current main without this PR

[OrlinVasilev]

nope! :(

let's merge that :)

[kaovilai]

without setting publish directory to public
Using this build settings for main
#6981 (comment)

I would expect would work without this PR and for future repo forkers who do not have anything set in netlify ui

[OrlinVasilev]

once again failed :

[kaovilai]

gotcha. Thanks for validating. Must be something else grandfathered in this account on another page.

[OrlinVasilev]

with my fix it's ok

[kaovilai]

diffing logs, will let you know if I spot something

[kaovilai]

❯ Flags
  baseRelDir: true

mine has baseRelDir true

Velero has baseRelDir: false
https://app.netlify.com/sites/velero/deploys/65316342d07d724c54eef0ec#L58

[kaovilai]

So your PR is not compatible with my netlify flags and vice versa :(

[kaovilai]

I need to ask somebody how to change this flag but based on docs it should be true for everyone else :(

Publish directory: directory that contains the deploy-ready HTML files and assets generated by the build. The directory is relative to the base directory

[kaovilai]

All paths configured in the netlify.toml should be absolute paths relative to the base directory, which is the root by default (/).

#

[kaovilai]

I'm good with this PR, at least the root cause for why netlify.toml of velero is not compatible with my netlify fork has been identified.

If you don't disagree that new netlify projects from future contributors (which will have baseRelDir: true) should work by default, I will make another PR in the future when I figure out how to change the baseRelDir flag either to document how to for future contributors, or to ask that velero update its netlify config to new default.

Thanks @OrlinVasilev again for troubleshooting with me!

[kaovilai]

heh.

baseRelDir

Boolean flag intended for backward compatibility. This is set for any sites created since the end of 2019.

When unset:

• The second pass when searching netlify.toml described above does not apply
• Paths in netlify.toml are relative to the repository root instead of the build directory

https://github.com/netlify/build/blob/72e33da1f3108c114b88ebd91602df2d325485a2/packages/config/docs/file_paths.md?plain=1#L60-L67

[OrlinVasilev]

@sseago can you review please

[codecov]

Codecov Report

Merging #6981 (36335ab) into main (fd8350f) will decrease coverage by 0.03%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6981      +/-   ##
==========================================
- Coverage   61.05%   61.02%   -0.03%     
==========================================
  Files         251      251              
  Lines       26845    26845              
==========================================
- Hits        16389    16381       -8     
- Misses       9303     9310       +7     
- Partials     1153     1154       +1     

see 1 file with indirect coverage changes

[OrlinVasilev]

THANK YOU