Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-1.12: kopia/repository/config/aws.go: Set session.Options profile from config #6997

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Oct 20, 2023

Signed-off-by: Tiger Kaovilai [email protected]

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #6998

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #6997 (72b5e7a) into release-1.12 (5c4fdfe) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

@@               Coverage Diff                @@
##           release-1.12    #6997      +/-   ##
================================================
- Coverage         60.47%   60.45%   -0.03%     
================================================
  Files               247      247              
  Lines             26399    26401       +2     
================================================
- Hits              15966    15960       -6     
- Misses             9312     9319       +7     
- Partials           1121     1122       +1     
Files Coverage Δ
pkg/repository/config/aws.go 41.26% <50.00%> (+1.92%) ⬆️

... and 1 file with indirect coverage changes

@kaovilai kaovilai force-pushed the kopias3profilecred-1.12 branch from 5f806a8 to 01cc1bd Compare October 20, 2023 18:32
@reasonerjt reasonerjt requested a review from Lyndon-Li October 23, 2023 06:26
@kaovilai kaovilai force-pushed the kopias3profilecred-1.12 branch from 01cc1bd to b4b7d61 Compare October 24, 2023 18:14
@Lyndon-Li
Copy link
Contributor

@kaovilai Please fix the CI error by run make update. Thanks.

@kaovilai kaovilai force-pushed the kopias3profilecred-1.12 branch from b4b7d61 to 72b5e7a Compare October 25, 2023 01:51
@kaovilai
Copy link
Member Author

done :)

@shubham-pampattiwar shubham-pampattiwar merged commit 32deef7 into vmware-tanzu:release-1.12 Oct 25, 2023
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants