Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable revive default rules #8609

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Jan 13, 2025

Thank you for contributing to Velero!

Please add a summary of your change

chore: enable revive default rules

Precising a rule on revive configuration overrrides the default one, this adds the default rules.
They will need to be fixed before being activated.

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

@mmorel-35
Copy link
Contributor Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.13%. Comparing base (5f7bf64) to head (298b8ad).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8609      +/-   ##
==========================================
- Coverage   59.15%   59.13%   -0.03%     
==========================================
  Files         370      370              
  Lines       39777    39777              
==========================================
- Hits        23532    23524       -8     
- Misses      14747    14754       +7     
- Partials     1498     1499       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35 mmorel-35 force-pushed the golangci-lint/revive branch 2 times, most recently from 975b81b to c9dfba5 Compare January 13, 2025 11:46
@mmorel-35 mmorel-35 force-pushed the golangci-lint/revive branch from c9dfba5 to 298b8ad Compare January 13, 2025 11:47
@kaovilai kaovilai merged commit ddc1bcb into vmware-tanzu:main Jan 14, 2025
41 of 42 checks passed
@mmorel-35 mmorel-35 deleted the golangci-lint/revive branch January 14, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants