Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.15] Always create DataUpload configmap in restore namespace #8622

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

sseago
Copy link
Collaborator

@sseago sseago commented Jan 16, 2025

Thank you for contributing to Velero!

Please add a summary of your change

In the DataUpload RIA, always create the ConfigMap in the Restore (velero) ns rather than the NS that the DataUpload was created in.
In most cases these are the same, but they won't be if the backup was done in a cluster with velero installed in namespace1 and the restore is being done with velero installed in namespace2. In this case, we need the configmap created in the namespace that velero is currently running in.

cherry-pick of #8621

Does your change fix a particular issue?

Fixes #8617

Please indicate you've done the following:

@sseago sseago force-pushed the datamover-new-ns-1.15 branch from 930cb67 to 233f3d0 Compare January 16, 2025 03:48
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.10%. Comparing base (804d73c) to head (233f3d0).
Report is 2 commits behind head on release-1.15.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.15    #8622   +/-   ##
=============================================
  Coverage         59.10%   59.10%           
=============================================
  Files               367      367           
  Lines             39178    39178           
=============================================
  Hits              23156    23156           
  Misses            14542    14542           
  Partials           1480     1480           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lyndon-Li Lyndon-Li merged commit 0d18f1d into vmware-tanzu:release-1.15 Jan 16, 2025
45 checks passed
@sseago sseago changed the title [release-1.15] Datamover new ns 1.15 [release-1.15]Datamover restore fails if restore cluster is using velero installed in a different namespace than velero on the backup cluster. Jan 16, 2025
@sseago sseago changed the title [release-1.15]Datamover restore fails if restore cluster is using velero installed in a different namespace than velero on the backup cluster. [release-1.15] Always create DataUpload configmap in restore namespace Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants