Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move storage to libs #2965

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

yontyon
Copy link
Contributor

@yontyon yontyon commented Mar 21, 2023

  • Problem Overview
    Move storage library to libs
  • Testing Done
    CI

@yontyon yontyon requested a review from toly-kournik March 21, 2023 12:51
@yontyon yontyon requested a review from a team as a code owner March 21, 2023 12:51
@yontyon yontyon force-pushed the move-storate-to-libs branch from b6760c5 to c411681 Compare March 28, 2023 10:24
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please git mv this file

@@ -31,7 +31,7 @@
#include "DbCheckpointMetadata.hpp"
#include "util/Metrics.hpp"
#include "InternalBFTClient.hpp"
#include "storage/db_interface.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and after it should remain #include "storage/db_interface.hpp"

@yontyon yontyon force-pushed the move-storate-to-libs branch 3 times, most recently from 78b079f to 6dca440 Compare March 30, 2023 08:38
@yontyon yontyon force-pushed the move-storate-to-libs branch from 6dca440 to 0362640 Compare April 13, 2023 06:39
@yontyon yontyon force-pushed the move-storate-to-libs branch from 0362640 to b8247f0 Compare April 16, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants