Handle logging #22
Merged
Handle logging #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haiks-2382
requested review from
lamngockhuong,
hoangntv-1399,
mannn-2274 and
khuongln-1346
...3/src/main/kotlin/com/vndevteam/kotlinwebspringboot3/infrastructure/logging/RequestFilter.kt
Outdated
Show resolved
Hide resolved
haiks-2382
added
the
type: feature
mannn-2274
reviewed
Oct 25, 2023
kotlin-web-spring-boot-3/src/main/kotlin/com/vndevteam/kotlinwebspringboot3/util/MapperUtils.kt
Outdated
Show resolved
Hide resolved
.../main/kotlin/com/vndevteam/kotlinwebspringboot3/infrastructure/logging/CustomResponseBody.kt
Outdated
Show resolved
Hide resolved
mannn-2274
reviewed
Oct 25, 2023
.../main/kotlin/com/vndevteam/kotlinwebspringboot3/infrastructure/logging/CustomResponseBody.kt
Outdated
Show resolved
Hide resolved
haiks-2382
force-pushed
the
feature.new.17
branch
5 times, most recently
from
56550b8 to
149dfa3
Compare
| } else { | ||
| UUID.randomUUID().toString() | ||
| } | ||
| return clientId |
There was a problem hiding this comment.
Thấy ở đây ngta có override thêm 2 method isAsyncDispatch và shouldNotFilterErrorDispatch hình như là để apply cho request lỗi. Hải check thử có cần thêm vào không nhé @haiks-2382
https://github.com/Verdoso/GreenSummer/blob/master/summer-core/src/main/java/org/greeneyed/summer/filter/Slf4jMDCFilter.java#L111
There was a problem hiding this comment.
t thêm rồi nhé,. Xem qua docs thì isAsyncDispatch là kiểu khi filter đc gọi từ 1 async dispatch thì mặc định sẽ ko call func doFilterInternal. shouldNotFilterErrorDispatch thì cũng tương tự mặc định ko call tới doFilterInternal, cụ thể liên quan tới việc response error nếu dùng thymleaf thì phải
...ot-3/src/main/kotlin/com/vndevteam/kotlinwebspringboot3/application/logging/RequestFilter.kt
Outdated
Show resolved
Hide resolved
...kotlin/com/vndevteam/kotlinwebspringboot3/application/logging/Slf4jMDCFilterConfiguration.kt
Outdated
Show resolved
Hide resolved
...ot-3/src/main/kotlin/com/vndevteam/kotlinwebspringboot3/application/logging/RequestFilter.kt
Outdated
Show resolved
Hide resolved
...ot-3/src/main/kotlin/com/vndevteam/kotlinwebspringboot3/application/logging/RequestFilter.kt
Outdated
Show resolved
Hide resolved
...ot-3/src/main/kotlin/com/vndevteam/kotlinwebspringboot3/application/logging/RequestFilter.kt
Outdated
Show resolved
Hide resolved
...kotlin/com/vndevteam/kotlinwebspringboot3/application/logging/Slf4jMDCFilterConfiguration.kt
Outdated
Show resolved
Hide resolved
| @Configuration | ||
| class Slf4jMDCFilterConfiguration { | ||
| companion object { | ||
| const val DEFAULT_RESPONSE_TOKEN_HEADER = "client_id" |
There was a problem hiding this comment.
Suggested change
| const val DEFAULT_RESPONSE_TOKEN_HEADER = "client_id" | |
| const val DEFAULT_RESPONSE_TOKEN_HEADER = "X-Client-Id" |
...src/main/kotlin/com/vndevteam/kotlinwebspringboot3/application/logging/CustomResponseBody.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/com/vndevteam/kotlinwebspringboot3/application/logging/CustomResponseBody.kt
Outdated
Show resolved
Hide resolved
...ot-3/src/main/kotlin/com/vndevteam/kotlinwebspringboot3/application/logging/RequestFilter.kt
Outdated
Show resolved
Hide resolved
| body: Any? | ||
| ) { | ||
| val requestId = httpServletRequest.getAttribute(RequestFilter.REQUEST_ID) | ||
| if (requestId != null) { |
There was a problem hiding this comment.
@haiks-2382 Phần log response time này Hải tách ra thành 1 filter khác như bài này nhé: https://stackoverflow.com/a/42858002/5718493
Để sau này mình dễ dàng bật tắt, đảm bảo các chức năng đc tách bạch không dồn chung vào 1 file
...src/main/kotlin/com/vndevteam/kotlinwebspringboot3/application/logging/CustomResponseBody.kt
Outdated
Show resolved
Hide resolved
haiks-2382
force-pushed
the
feature.new.17
branch
from
149dfa3 to
a433a9c
Compare
haiks-2382
force-pushed
the
feature.new.17
branch
from
a433a9c to
7881823
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Handle logging
Description
#17
Checklist
Evidence
(Screenshot or Video)
Discussion
Note the part that you are not sure. Comment on your code is OK.