Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

astroid: build with guri and webkit2gtk-4.1 #49013

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

oreo639
Copy link
Member

@oreo639 oreo639 commented Feb 29, 2024

Testing the changes

  • I tested the changes in this PR: briefly

@bitmeise Can you test this and verify if it works for you?

@bitmeise
Copy link
Contributor

bitmeise commented Mar 1, 2024

I can confirm that this patch works me (smoke tested). Are there any visible changes I should look out for?
Where is this patch coming from?

Also, you should bump the revision.

@oreo639
Copy link
Member Author

oreo639 commented Mar 1, 2024

Are there any visible changes I should look out for?

The only real change is for the URI parsing for astroid --mailto, to use Glib instead of libsoup-2.0.

Where is this patch coming from?

astroidmail/astroid#745

@bitmeise
Copy link
Contributor

bitmeise commented Mar 2, 2024

I'm just curious: Is this about getting rid of old dependencies in the ecosystem from a Void perspective?
As a small contributor I'm definitely fine with the changes. I generally think though that changes should be integrated upstream as often as possible. We could wait for them to do so.

Well, in that case, you are the Void member :)

@oreo639
Copy link
Member Author

oreo639 commented Mar 2, 2024

Is this about getting rid of old dependencies in the ecosystem from a Void perspective?

webkit2gtk is a massive dependency and having to compile it 3 times is not ideal. Many distros have already stopped shipping webkit2gtk-4.0 and the changes in this case are relatively simple. (the guri changes are necessary since libsoup2 and libsoup3 cannot be loaded in the same process at the same time, and libsoup3 removed the SoupUri api)

I generally think though that changes should be integrated upstream as often as possible.

Of course, that is why I submitted a PR upstream and this is marked as a draft.

Copy link

github-actions bot commented Jun 1, 2024

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jun 1, 2024
@oreo639
Copy link
Member Author

oreo639 commented Jun 1, 2024

bump

@oreo639 oreo639 marked this pull request as ready for review June 18, 2024 23:37
@oreo639 oreo639 merged commit 62f6da1 into void-linux:master Jun 21, 2024
8 checks passed
@oreo639 oreo639 deleted the astroid branch June 21, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants