Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gst-plugins-bad1: enable build with nvcodec #54128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TorMFinn
Copy link

This change adds the nv-codec-headers package as a build dependency to gst-plugins-bad1 enabling the build of the nvcodec plugins.

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

Copy link
Member

@classabbyamp classabbyamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revision needs to be incremented

@TorMFinn
Copy link
Author

Thanks! I have bumped the revision and fixed a trailing whitespace

@zlice
Copy link
Contributor

zlice commented Jan 28, 2025

fyi, update here #53936

@TorMFinn
Copy link
Author

fyi, update here #53936

Then I assume the correct way to merge this would be to wait till 1.24.11 gets merged and then rebase my branch?

@zlice
Copy link
Contributor

zlice commented Jan 29, 2025

just a heads up. similar thing happened with blender a bit back and theyre in limbo

@classabbyamp
Copy link
Member

it's not in "limbo", both PRs had unaddressed feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants