New package: firefox-ublock-origin-1.62.0 #54135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahesford
previously requested changes
Jan 28, 2025
There was a problem hiding this comment.
Drop the INSTALL.msg; that's for mission-critical notices, generally about breaking changes in new versions of software. Messages that teach people how to use software just add noise that is likely to be overlooked or ignored anyway.
I'm not convinced that there's enough value in this package to accept it.
Comment on lines
21
to
23
| mkdir -p uBlock-${version}/dist/build/uAssets | ||
| mv uAssets-${_uassets_master} uBlock-${version}/dist/build/uAssets/main | ||
| mv uAssets-${_uassets_ghpages} uBlock-${version}/dist/build/uAssets/prod |
There was a problem hiding this comment.
See vsrcextract for a better way to manage this.
Comment on lines
26
to
27
| do_build() { | ||
| cd uBlock-${version} | ||
| make firefox | ||
| } |
There was a problem hiding this comment.
This is unnecessary, whether you adopt vsrcextract or not. Without vsrcextract, you probably need to set build_wrksrc. In either case, just set make_build_target="firefox".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
New package
Local build testing
I've based this template on Alpine's one.
Installs uBlock Origin for Firefox systemwide.
I'm going to use it in some deployments.
Is this package any good? Or shouldn't it be in repo?
Extension is installed same way as in
firefox-i18nandfirefox-esr-i18npackages.