Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add manpage to the lsd package #54229

Closed
wants to merge 2 commits into from
Closed

Conversation

bart9h
Copy link

@bart9h bart9h commented Feb 5, 2025

I noticed that the lsd tool was missing a manpage, so I edited the template file to use pandoc to generate a manpage from the doc/lsd.md that was already present in the sources.

I noticed that the `lsd` tool was missing a manpage, so I edited the template file to use pandoc to generate a manpage from the doc/lsd.md that was already present in the sources.
@classabbyamp
Copy link
Member

commit message should be just lsd: add manpage, and the commit message body isn't necessary

@@ -3,7 +3,7 @@ pkgname=lsd
version=1.1.5
revision=1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revsion needs to be incremented so it will rebuild

Copy link
Author

@bart9h bart9h Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that in the guidelines after I made the pull request. But I didn't know how to add a commit to an existing PR.

I just found out now. Sorry for the inconvenience.

Copy link
Member

@classabbyamp classabbyamp Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can do git reset --soft HEAD~2 to get back to before your commits, then recommit with git commit

in the future, you can use git commit --amend to edit the message and contents of the commit

both of these actions require git push --force to update the PR once done

@tranzystorekk
Copy link
Contributor

Superseded by #54232, still, thank you for reporting and working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants