WIP: naive attempt at fixing average aggregation breaking deduplication #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrakid
approved these changes
Oct 3, 2021
r00t-
commented
Oct 3, 2021
src/api/Volkszaehler.cpp
Outdated
| @@ -213,7 +213,7 @@ json_object *vz::api::Volkszaehler::api_json_tuples(Buffer::Ptr buf) { | |||
| // a) timestamp | |||
| // b) duplicate value | |||
| if ((timestamp >= (_last_timestamp + duplicates_ms)) || | |||
| (r.value() != _lastReadingSent->value())) { | |||
| (fabs(r.value() - _lastReadingSent->value()) > 0.000001 )) { | |||
There was a problem hiding this comment.
i think the tolerance for the comparison (0.000...01) needs to be chosen in relation to the input values, for this to work with numbers in any range,
but my short research did not lead to a best-practice algorithm to use.
(probably needs a float number with it's exponent derived from the exponent of the inputs.)
There was a problem hiding this comment.
r00t-
force-pushed
the
fix_avg_aggregation_breaking_deduplication
branch
3 times, most recently
from
e4a2b2c to
d523173
Compare
…reaking deduplication
r00t-
force-pushed
the
fix_avg_aggregation_breaking_deduplication
branch
from
d523173 to
72903cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
naive and likely incorrect attempt at fixing average aggregation breaking deduplication
attempting to fix #500