-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use @action/cache to cache where possible #27
Comments
Would be great to have this feature implemented |
Was wondering if this request includes caching of yarn packages. Not a huge problem but would be nice to see yarn/npm/pnpm package caching as well. |
@just-Bri - Yes, I was thinking that would be included when we do this work... |
I figured as much but wanted to call it out directly to make sure. The issue doesn't specify caching of installed node packages, I was afraid it was referring to just Volta/node/npm/yarn/pnpm and not the packages installed installed via an |
Anyone mind mentoring me on implementing this feature? I use |
you can use the pinned volta version from package.json with setup-node action
Or you can role your own with volta action and the cache action |
Would really be nice if the action would just cache and restore the downloaded tools, since I ran into a situation multiple times now, where the Node Download timed out. It would not need to be downloaded again if it would be cached since the version does not change most of the time anyway. |
you might just want a GH / NPM token to prevent timeouts @cgrabmann
|
There are a few scenarios where we could take advantage of the newly published caching package:
node-version
oryarn-version
. We should be able to cache based on thevolta
key inpackage.json
, and avoid having to download node/volta/etc if nothing has changed.node-version: 12.x
. This is a bit trickier than the prior scenario since it is not obvious how to comprise the cache key so that you do get a newer versions within your allowed range "periodically". Ideally we do not need to duplicate the logic in Volta itself for determining the node versions.The text was updated successfully, but these errors were encountered: