Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: upgrade to Astro v5 & Node.js v22 #223

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jbmoelker
Copy link
Member

@jbmoelker jbmoelker commented Dec 5, 2024

Changes

  • Upgrade to Astro v5 (stable) and Node.js v22 (latest LTS version).
  • Upgrade related packages (adapters, linter, etc).

Associated issue

Resolves #188

How to test

  1. Open preview link
  2. Verify all pages still work
  3. Verify preview mode still works

Checklist

  • I have performed a self-review of my own code
  • I have made sure that my PR is easy to review (not too big, includes comments)
  • I have made updated relevant documentation files (in project README, docs/, etc)
  • I have added a decision log entry if the change affects the architecture or changes a significant technology
  • I have notified a reviewer

@jbmoelker jbmoelker force-pushed the feat/astro-v5-nodejs-v22 branch from 4cc7222 to ee00224 Compare December 5, 2024 14:09
Copy link

cloudflare-workers-and-pages bot commented Dec 5, 2024

Deploying head-start with  Cloudflare Pages  Cloudflare Pages

Latest commit: e2f87ba
Status: ✅  Deploy successful!
Preview URL: https://6c1dd9bf.head-start.pages.dev
Branch Preview URL: https://feat-astro-v5-nodejs-v22.head-start.pages.dev

View logs

@jbmoelker jbmoelker marked this pull request as draft December 5, 2024 14:09
@jbmoelker jbmoelker added the help wanted Extra attention is needed label Dec 5, 2024
@jbmoelker
Copy link
Member Author

Blocked as Astro v5 uses Vite v6, while Vitest still uses (/ has reverted to) Vite v5 🤷. Issue has been filled: withastro/astro#12662 .
We could try suggested override as a workaround or wait for Vitest to update to Vite v6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Astro v5
1 participant