Add support for GIFs in responsive video component #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siilwyn
requested changes
Apr 26, 2024
Comment on lines
+24
to
+37
| <video | ||
| v-else-if="props.gif" | ||
| class="responsive-video" | ||
| autoplay | ||
| controls | ||
| :style="{ | ||
| aspectRatio: `${props.gif.width} / ${props.gif.height}`, | ||
| }" | ||
| > | ||
| <source | ||
| :src="`${props.gif.url}?fm=mp4`" | ||
| type="video/mp4" | ||
| > | ||
| </video> |
There was a problem hiding this comment.
Hmm I don't know if this is the way to go, can't we use vue-dato-video for this?
Would like some more context, it's not really a gif right but a mp4 video that autoplays?
There was a problem hiding this comment.
I agree that, if possible, this should be formatted so you can use the vue-dato-video for both
WesselSmit
suggested changes
May 27, 2024
| </template> | ||
|
|
||
| <script setup lang="ts"> | ||
| import "@voorhoede/vue-dato-video/style"; | ||
| import { VueDatoVideo } from "@voorhoede/vue-dato-video"; | ||
| import { VueDatoVideo, } from "@voorhoede/vue-dato-video"; |
There was a problem hiding this comment.
Suggested change
| import { VueDatoVideo, } from "@voorhoede/vue-dato-video"; | |
| import { VueDatoVideo } from "@voorhoede/vue-dato-video"; |
Comment on lines
+24
to
+37
| <video | ||
| v-else-if="props.gif" | ||
| class="responsive-video" | ||
| autoplay | ||
| controls | ||
| :style="{ | ||
| aspectRatio: `${props.gif.width} / ${props.gif.height}`, | ||
| }" | ||
| > | ||
| <source | ||
| :src="`${props.gif.url}?fm=mp4`" | ||
| type="video/mp4" | ||
| > | ||
| </video> |
There was a problem hiding this comment.
I agree that, if possible, this should be formatted so you can use the vue-dato-video for both
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were made
responsive-videocomponentresponsive-videoHow to test or check results
Checks