feat/blog-post-scripts #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WesselSmit
changed the title
jurgenbelien
approved these changes
Aug 30, 2024
jurgenbelien
force-pushed
the
feat/blog-post-scripts
branch
from
d6de013 to
1b62fe0
Compare
Siilwyn
requested changes
Jan 15, 2025
| <template> | ||
| <div class="custom-script"> | ||
| <!-- we show a <noscript> element if the user has javascript disabled, this is necessary because some functionality might be broken due to javascript being disabled and its important that users are notified why it isn't working --> | ||
| <!-- this needs to be v-html instead of your typical {{ someValue }} interpolation because of a bug that content in noscript does not seem to be evaluated by Vue --> |
There was a problem hiding this comment.
Not sure this is a bug, feels like intended behaviour? Maybe we can just mention it's not being evaluated?
There was a problem hiding this comment.
You're right, not a bug!
| if (props.unmountScript) { | ||
| const unmountScript = runScriptInBrowser(props.unmountScript, onUnmountScriptId); | ||
|
|
||
| // how to ensure the unmountScript has a chance to be executed in the browser? |
There was a problem hiding this comment.
Since runScriptInBrowser is sync this shouldn't be an issue right?
Could add nextTick before removal to give it some extra time.
There was a problem hiding this comment.
That was our assumption as well, will remove
jurgenbelien
force-pushed
the
feat/blog-post-scripts
branch
from
35c8ccf to
bedfc58
Compare
Siilwyn
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were made
Ticket
https://trello.com/c/SJizgBYO/753-as-a-writer-i-want-to-add-javascript-to-my-blog-post-so-i-can-have-interactive-examples
How to test or check results
Checks