Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Username and Email are empty, set Username to Name #440

Closed
wants to merge 1 commit into from
Closed

When Username and Email are empty, set Username to Name #440

wants to merge 1 commit into from

Conversation

epicfilemcnulty
Copy link

Since #309 is still on hold, @bnfinet would you be willing to accept a small fix? It should fix the issue for some providers, tested with PingFed.

@bnfinet
Copy link
Member

bnfinet commented Oct 16, 2021

@epicfilemcnulty that's on me

I appreciate what you're trying to do here but the real fix is to put the real fix in. I keep on hoping to find a window where I can tweak the existing efforts and review them and write a few tests. That keeps on getting pushed out for non VP related reasons.

Thanks for the contribution but I'm going to close in hopes of being able to commit effort to getting sub in properly.

@bnfinet bnfinet closed this Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants