Release 2.0.0 #84
Merged
Release 2.0.0 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwaffen
approved these changes
Feb 21, 2024
bastelfreak
reviewed
Feb 21, 2024
Comment on lines
+20
to
+24
| - Do not allow bootstrap tokens with a leading newline [\#80](https://github.com/voxpupuli/puppet-k8s/pull/80) ([olavst-spk](https://github.com/olavst-spk)) | ||
| - Do not allow bootstrap tokens with a trailing newline [\#79](https://github.com/voxpupuli/puppet-k8s/pull/79) ([olavst-spk](https://github.com/olavst-spk)) |
There was a problem hiding this comment.
I added the bugfix label, please regenerate the changelog
bastelfreak
reviewed
Feb 21, 2024
CHANGELOG.md
Outdated
| **Merged pull requests:** | ||
|
|
||
| - Use a template string for the crictl download URL [\#83](https://github.com/voxpupuli/puppet-k8s/pull/83) ([olavst-spk](https://github.com/olavst-spk)) | ||
| - Make cni\_plugins download url configurable with a template string [\#82](https://github.com/voxpupuli/puppet-k8s/pull/82) ([olavst-spk](https://github.com/olavst-spk)) |
There was a problem hiding this comment.
added the enhancement label
bastelfreak
reviewed
Feb 21, 2024
|
|
||
| [Full Changelog](https://github.com/voxpupuli/puppet-k8s/compare/015d6134ae3d9b40ca539c9439a0de79374bc27a...v1.0.0) | ||
|
|
||
| **Breaking changes:** |
There was a problem hiding this comment.
looks odd that the whole section was missing 🤔
h-haaks
force-pushed
the
release-prep
branch
from
6a581ce to
6a29268
Compare
bastelfreak
reviewed
Feb 21, 2024
|
|
||
| **Implemented enhancements:** | ||
|
|
||
| - Make cni\_plugins download url configurable with a template string [\#82](https://github.com/voxpupuli/puppet-k8s/pull/82) ([olavst-spk](https://github.com/olavst-spk)) |
There was a problem hiding this comment.
Oh so this looks like a breaking change because it drops a parameter in a class that isn't private? In that case we have to do a 2.0.0 release.
There was a problem hiding this comment.
I guess #83 is also a breaking change then?
There was a problem hiding this comment.
Added labels and changed metadata to 2.0.0
h-haaks
force-pushed
the
release-prep
branch
from
6a29268 to
c933adb
Compare
|
i would give it a go now.... you ok @bastelfreak ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Prepare 2.0.0 release