Set Default file mode to 0600 as config could contain connection strings

voxpupuli · Apr 29, 2024 · 39f4dd2 · 39f4dd2
1 parent bd3cb26
commit 39f4dd2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/REFERENCE.md b/REFERENCE.md
@@ -148,7 +148,7 @@ Data type: `Stdlib::Filemode`
 
 mode of config_file
 
-Default value: `'0644'`
+Default value: `'0600'`
 
 ##### <a name="-otelcol--receivers"></a>`receivers`
 

diff --git a/manifests/init.pp b/manifests/init.pp
@@ -60,7 +60,7 @@
   String  $config_file                           = "/etc/${package_name}/config.yaml",
   String  $config_file_owner                     = 'root',
   String  $config_file_group                     = 'root',
-  Stdlib::Filemode $config_file_mode             = '0644',
+  Stdlib::Filemode $config_file_mode             = '0600',
   Hash[String, Hash] $receivers = {},
   Hash[String, Hash] $processors = {},
   Hash[String, Hash] $exporters = {},

diff --git a/spec/classes/otelcol_spec.rb b/spec/classes/otelcol_spec.rb
@@ -17,6 +17,7 @@
           is_expected.to contain_concat('otelcol-config').with({
                                                                  'path' => '/etc/otelcol/config.yaml',
                                                                  'format' => 'yaml',
+                                                                 'mode' => '0600',
                                                                })
           is_expected.to contain_concat__fragment('otelcol-config-header')
           is_expected.to contain_concat__fragment('otelcol-config-baseconfig')
@@ -150,7 +151,7 @@
           {
             config_file_owner: 'root',
             config_file_group: 'root',
-            config_file_mode: '0600',
+            config_file_mode: '0640',
           }
         end
 
@@ -160,7 +161,7 @@
           is_expected.to contain_concat('otelcol-config').with(
             'owner' => 'root',
             'group' => 'root',
-            'mode'  => '0600'
+            'mode'  => '0640'
           )
         }
       end