Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow percent (%) character in unit names. #401

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

traylenator
Copy link
Contributor

@traylenator traylenator commented Dec 14, 2023

Pull Request (PR) description

This allows relations to be set up between similar instances of two templated units.

For example:

systemd::manage_dropin{'user-aklog.conf':
  ensure     => present,
  unit       => '[email protected]',
  unit_entry => {
    'Documentation' => 'Run an aklog before we start systemd --user',
    'After'         => ['user-aklog@%i.service'],
    'Requires'      => ['user-aklog@%i.service'],
  },
}

Previously the % character was considered illegal in a unit name.

@traylenator traylenator added the enhancement New feature or request label Dec 14, 2023
This allows relations to be set up between similar instances of
two templated units.

For example:

```puppet
systemd::manage_dropin{'user-aklog.conf':
  ensure     => present,
  unit       => '[email protected]',
  unit_entry => {
    'Documentation' => 'Run an aklog log before we start systemd --user',
    'After'         => ['user-aklog@%i.service'],
    'Requires'      => ['user-aklog@%i.service'],
  },
}
```

Previously the `%` character was considered illegal in a unit name.
@traylenator
Copy link
Contributor Author

A brilliant ratio of code to docs and tests. 🥱

@traylenator traylenator merged commit f9dd68f into voxpupuli:master Dec 14, 2023
34 checks passed
@traylenator traylenator deleted the instace_relation branch December 14, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants